Fixes from type hints - #1342
Merged
Merged
Conversation
Member
Author
|
The issues I added to the changelog are actually in the current releases. I wonder why the default PIN thing didn't bite us yet. 🤔 |
Contributor
BlueZ handles most keyboard, mice and other devices with default pins. The defaults still left are for more rare devices which I don't own and very likely neither do you. |
infirit
previously approved these changes
Aug 18, 2020
Sendto.on_session_failed expects msg to be a BluezDBusException but the signal transports it as a str, obtained by PyGObject by calling __str__ since dd75308.
set_search_equal_func either must not receive user data or search_func must take it as an additional argument. It actually got added in blueman-project#29 to the call but not to the method. I do not see how that could have worked but maybe something else changed that broke it along the way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some actual fixes for issues found while adding type hints, cherry-picked from #1338 #1340 #1341.