Enable mypy --disallow-untyped-calls --disallow-untyped-defs - #1345
Merged
Conversation
cschramm
force-pushed
the
types-polish
branch
5 times, most recently
from
August 20, 2020 19:58
c81f0ba to
2121825
Compare
We're basically mypy --strict now, just --disallow-subclassing-any is missing as all the untyped GLib / Gtk classes we inherit from are considered Any. This can be fixed by adding stubs for them which will reveal all kinds of edge cases I guess.
infirit
approved these changes
Aug 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're basically mypy --strict now, just --disallow-subclassing-any is missing as all the untyped GLib / Gtk classes we inherit from are considered Any. This can be fixed by adding stubs for them which will reveal all kinds of edge cases I guess.
Depends on #1338 #1340 #1341.