Fix Gemini ACP model IDs with Google provider prefixes - #1030
Conversation
|
I have Gemini API credit available, so I was able to run the live checks that Short version: this PR fixes the reported bug, and it fixes strictly more than Setup
Live A/B
The The 404 in #975, confirmed end to endThe empty error message in the original report ( Which is exactly what the CLI then surfaces: Empty body -> empty message -> Tests, lint, and mutation
Non-regression, identical on all three trees: SuggestionLand this implementation, and consider folding in #979's parametrized case in Minor: this PR describes #975 but does not use a closing keyword, so it is not Everything above was validated end to end against the live Gemini API — real |
|
#979 will close unmerged after this replacement lands. Its stronger Validation after merging current |
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
|
Addressed Devin’s |
Fixes #975
Summary
google/gemini-*andgoogle/gemma-*IDs to bare model IDs on the Gemini ACP path.gemini/provider prefix when routing through the generic LiteLLM gateway.google/*model IDs.connect_acp->session/set_modelregression coverage for Gemini and Gemma, plus focused gateway boundary coverage.Validation
uv run pytest -q tests/test_acp.py tests/test_litellm_config.py tests/test_litellm_hardening.py-> 175 passed after merging currentmain.@google/gemini-cli@0.42.0and Google GenerateContent returned 200 for normalized Gemini and Gemma IDs; prefixed IDs reproduced the provider 404.