Skip to content

Add Z.ai Coding Plan routing - #1074

Open
kywch wants to merge 4 commits into
fix/gemini-acp-model-idfrom
fix/zai-coding-routing
Open

Add Z.ai Coding Plan routing#1074
kywch wants to merge 4 commits into
fix/gemini-acp-model-idfrom
fix/zai-coding-routing

Conversation

@kywch

@kywch kywch commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • add explicit Z.ai Coding Plan provider, key, and endpoint routing
  • reject registry-derived base URLs that do not match proxy protocol
  • forward only validated generation parameters, using correct token field for Responses versus chat and native routes
  • support current catalog entries and unlisted future GLM 5.x model IDs

Validation

  • 296 focused tests passed
  • Ruff, format, and git diff --check passed
  • exact-head integration matrix completed all 10 selected arXiv conditions; OpenClaw and Claude ACP Z.ai conditions both earned reward 1
  • full matrix had zero sandbox or trial errors; sole zero reward was unrelated Gemini provider 429

Review

This PR is intentionally stacked on #1030. After #1030 merges, retarget to main and verify final diff.

Maintainer or other-person review required. Author will not self-merge.

@kywch
kywch deployed to pypi-internal-preview August 31, 2026 01:45 — with GitHub Actions Active

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

2 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)

Devin Review

Comment thread src/benchflow/providers/litellm_config.py Outdated
@kywch
kywch deployed to pypi-internal-preview August 31, 2026 02:19 — with GitHub Actions Active
@kywch

kywch commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator Author

Addressed endpoint-provenance finding: registry-generated provider env now carries explicit provenance, while user-supplied endpoints remain authoritative. Added direct, resolved-explicit, and registry-generated regressions. Refreshed onto #1030 head 5fbf930; all applicable CI checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant