fix(judge): parse native edit targets - #1069
Open
kywch wants to merge 2 commits into
Open
Conversation
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Editing <path>targets from native OpenHands ACP edit titles.editevents; malformed, trailing-prose, and unrecognized titles retain conservative full-title scanning.Why
A confirmed live rollout earned reward 1.0 and passed the LLM judge, but the mechanical tamper gate rejected native edits to
/tmp/test_logistic.pyand/tmp/test_rnn.py. OpenHands recorded those targets in titles such asCreate test script: Editing /tmp/test_rnn.py; scanning the whole title matched the test-like filename before the scratch-path exemption could apply.Failed job: https://github.com/benchflow-ai/benchflow/actions/runs/31622440593/job/94200401493
Behavior
The scanner now extracts only an exact trailing
Editing <path>target for native ACPeditevents. Protected targets remain flagged. Non-edit events and malformed titles remain fail-closed. Lexical normalization prevents paths such as/tmp/../verifier/test.shfrom receiving the scratch exemption, including during shell-command masking.Tests
/tmpedit titleFocused result: 59 passed, 1 deselected. Ruff check and format checks pass.
Provenance
Extracts and hardens the judge fix originally authored in #979 commit
bc9a1c3. This separates judge behavior from #979 and #1030 Gemini model-routing scope while preserving the original author through the existing repository author identity.