fix(revenue-analytics): Groups materialized view joins

[arthurdedeus]

Problem

Same as #52929, but for groups.

Part of #52270

Changes

Reuse test setup and util functions to fix the bug for groups.

How did you test this code?

Unit tests

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Publish to changelog?

no

Docs update

no

[arthurdedeus]

• feat(stripe-mock): Add subscription_metadata and charge_metadata config #53596
• feat(revenue-analytics): Resolve posthog_person_distinct_id from child Stripe objects #53595
• fix(revenue-analytics): Use correct field name in persons join #53594
• fix(revenue-analytics): Groups materialized view joins #53119 👈 (View in Graphite)
• fix(revenue-analytics): Persons materialized view joins #52929
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Prompt To Fix All With AI

This is a comment left during a code review.
Path: posthog/hogql/database/schema/test/test_groups_revenue_analytics.py
Line: 466-469

Comment:
**Redundant `setUp` causes mock leak**

`RevenueAnalyticsManagedViewsetsTestMixin.setUp` already patches `posthoganalytics.feature_enabled` and assigns it to `self.mock_flag`. When `TestGroupsRevenueAnalyticsManagedViewsets.setUp` calls `super().setUp()` first, the mixin's patch is started and `self.mock_flag` is set. Then this method immediately overwrites `self.mock_flag` with a second patch and starts it too.

The result is two active patches for `posthoganalytics.feature_enabled`, but `tearDown` (inherited from the mixin) only calls `self.mock_flag.stop()` once — stopping only the second patch. The first patch leaks, potentially affecting subsequent tests.

The `setUp` override here is already handled by the mixin via `super().setUp()`, so it should be removed entirely. Compare with `TestPersonsRevenueAnalyticsManagedViewsets`, which correctly relies on the mixin's `setUp` without overriding it.

```suggestion
class TestGroupsRevenueAnalyticsManagedViewsets(
    TestGroupsRevenueAnalyticsMixin, RevenueAnalyticsManagedViewsetsTestMixin
):
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix: Support materialized views in group..." | Re-trigger Greptile}

[github-actions]

🎭 Playwright report · View test results →

⚠️ 1 flaky test:

• Materialize view pane (chromium)

These issues are not necessarily caused by your changes.
Annoyed by this comment? Help fix flakies and failures and it'll disappear!