feat(stripe-mock): Add subscription_metadata and charge_metadata config

[arthurdedeus]

Problem

The stripe-mock service applied customer_metadata to all object types (customer, subscription, charge), making it impossible
to test scenarios where posthog_person_distinct_id is set on subscriptions or charges but not on the customer.

Part of #52270

Changes

• Added subscription_metadata and charge_metadata config fields to stripe-mock, each injected only into their respective
  object type
• Updated default config comments with examples

How did you test this code?

Verified stripe-mock generates correct per-object metadata via local dev testing.

Publish to changelog?

No

Docs update

no

[arthurdedeus]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(stripe-mock): Add subscription_metadata and charge_metadata config #53596 👈 (View in Graphite)
• feat(revenue-analytics): Resolve posthog_person_distinct_id from child Stripe objects #53595
• fix(revenue-analytics): Use correct field name in persons join #53594
• fix(revenue-analytics): Groups materialized view joins #53119
• fix(revenue-analytics): Persons materialized view joins #52929
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[stamphog]

Gates denied this PR because it touches billing-related code (stripe-mock), which is on the deny-list and requires human review.

[greptile-apps]

Comments Outside Diff (1)

1. services/stripe-mock/tests/test_scenarios.py, line 143-167 (link)

   Missing test coverage for subscription_metadata and charge_metadata

   The existing test_custom_metadata_injected test only verifies that customer_metadata is applied to customers. The new subscription_metadata and charge_metadata fields — which are the core feature of this PR — have no test coverage at all. There is also no test verifying the isolation guarantee (e.g. that subscription_metadata does NOT appear on customers or charges).

   Per the project's preference for parameterised tests, consider expanding this into something like:

   @pytest.mark.parametrize(
       "field,collection",
       [
           ("customer_metadata", "customers"),
           ("subscription_metadata", "subscriptions"),
           ("charge_metadata", "charges"),
       ],
   )
   def test_metadata_injected_per_object_type(self, field, collection):
       cfg = MockConfig(
           **{field: {"env": "test"}},
           customer_types={
               "loyalists_monthly": 1,
               "loyalists_annual": 0,
               "churners": 0,
               "resubscribers": 0,
               "upgraders": 0,
               "downgraders": 0,
               "interval_switchers": 0,
               "coupon_users": 0,
               "multi_currency_eur": 0,
               "multi_currency_gbp": 0,
               "multi_currency_jpy": 0,
               "refund_recipients": 0,
               "trial_users": 0,
               "late_joiners": 0,
               "edge_combos": 0,
           },
       )
       collections = build_from_config(cfg)
       assert collections[collection][0]["metadata"]["env"] == "test"

   Prompt To Fix With AI

   This is a comment left during a code review.
   Path: services/stripe-mock/tests/test_scenarios.py
   Line: 143-167
   
   Comment:
   **Missing test coverage for `subscription_metadata` and `charge_metadata`**
   
   The existing `test_custom_metadata_injected` test only verifies that `customer_metadata` is applied to customers. The new `subscription_metadata` and `charge_metadata` fields — which are the core feature of this PR — have no test coverage at all. There is also no test verifying the isolation guarantee (e.g. that `subscription_metadata` does NOT appear on customers or charges).
   
   Per the project's preference for parameterised tests, consider expanding this into something like:
   
   ```python
   @pytest.mark.parametrize(
       "field,collection",
       [
           ("customer_metadata", "customers"),
           ("subscription_metadata", "subscriptions"),
           ("charge_metadata", "charges"),
       ],
   )
   def test_metadata_injected_per_object_type(self, field, collection):
       cfg = MockConfig(
           **{field: {"env": "test"}},
           customer_types={
               "loyalists_monthly": 1,
               "loyalists_annual": 0,
               "churners": 0,
               "resubscribers": 0,
               "upgraders": 0,
               "downgraders": 0,
               "interval_switchers": 0,
               "coupon_users": 0,
               "multi_currency_eur": 0,
               "multi_currency_gbp": 0,
               "multi_currency_jpy": 0,
               "refund_recipients": 0,
               "trial_users": 0,
               "late_joiners": 0,
               "edge_combos": 0,
           },
       )
       collections = build_from_config(cfg)
       assert collections[collection][0]["metadata"]["env"] == "test"
   ```
   
   How can I resolve this? If you propose a fix, please make it concise.

   _{Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!}

Prompt To Fix All With AI

This is a comment left during a code review.
Path: services/stripe-mock/src/stripe_mock/data/scenarios.py
Line: 288

Comment:
**`charge_metadata` computed inside loop**

Unlike `customer_metadata` and `subscription_metadata` (which are built once before the loop on lines 148–149), `charge_metadata` is recomputed on every monthly iteration even though neither `self.cfg.charge_metadata` nor `persona_metadata` changes during the loop. For consistency, hoist it alongside the other two metadata variables before the loop starts:

```suggestion
            charge_metadata = {**self.cfg.charge_metadata, **(persona_metadata or {})}
```

(Add this line after line 149, and remove it from inside the loop.)

How can I resolve this? If you propose a fix, please make it concise.

---

This is a comment left during a code review.
Path: services/stripe-mock/tests/test_scenarios.py
Line: 143-167

Comment:
**Missing test coverage for `subscription_metadata` and `charge_metadata`**

The existing `test_custom_metadata_injected` test only verifies that `customer_metadata` is applied to customers. The new `subscription_metadata` and `charge_metadata` fields — which are the core feature of this PR — have no test coverage at all. There is also no test verifying the isolation guarantee (e.g. that `subscription_metadata` does NOT appear on customers or charges).

Per the project's preference for parameterised tests, consider expanding this into something like:

```python
@pytest.mark.parametrize(
    "field,collection",
    [
        ("customer_metadata", "customers"),
        ("subscription_metadata", "subscriptions"),
        ("charge_metadata", "charges"),
    ],
)
def test_metadata_injected_per_object_type(self, field, collection):
    cfg = MockConfig(
        **{field: {"env": "test"}},
        customer_types={
            "loyalists_monthly": 1,
            "loyalists_annual": 0,
            "churners": 0,
            "resubscribers": 0,
            "upgraders": 0,
            "downgraders": 0,
            "interval_switchers": 0,
            "coupon_users": 0,
            "multi_currency_eur": 0,
            "multi_currency_gbp": 0,
            "multi_currency_jpy": 0,
            "refund_recipients": 0,
            "trial_users": 0,
            "late_joiners": 0,
            "edge_combos": 0,
        },
    )
    collections = build_from_config(cfg)
    assert collections[collection][0]["metadata"]["env"] == "test"
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "feat(stripe-mock): Add subscription_meta..." | Re-trigger Greptile}

[greptile-apps]

charge_metadata computed inside loop

Unlike customer_metadata and subscription_metadata (which are built once before the loop on lines 148–149), charge_metadata is recomputed on every monthly iteration even though neither self.cfg.charge_metadata nor persona_metadata changes during the loop. For consistency, hoist it alongside the other two metadata variables before the loop starts:

Suggested change

	charge_metadata = {**self.cfg.charge_metadata, **(persona_metadata or {})}
	charge_metadata = {**self.cfg.charge_metadata, **(persona_metadata or {})}

(Add this line after line 149, and remove it from inside the loop.)

Prompt To Fix With AI

This is a comment left during a code review.
Path: services/stripe-mock/src/stripe_mock/data/scenarios.py
Line: 288

Comment:
**`charge_metadata` computed inside loop**

Unlike `customer_metadata` and `subscription_metadata` (which are built once before the loop on lines 148–149), `charge_metadata` is recomputed on every monthly iteration even though neither `self.cfg.charge_metadata` nor `persona_metadata` changes during the loop. For consistency, hoist it alongside the other two metadata variables before the loop starts:

```suggestion
            charge_metadata = {**self.cfg.charge_metadata, **(persona_metadata or {})}
```

(Add this line after line 149, and remove it from inside the loop.)

How can I resolve this? If you propose a fix, please make it concise.

[vdekrijger]

The greptile comment seems fair, but since it's a mock I guess it's not that big of an issue 😄