Skip to content

fix(revenue-analytics): Groups materialized view joins #53119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arthurdedeus merged 5 commits into from
Apr 7, 2026
Merged

fix(revenue-analytics): Groups materialized view joins #53119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b7abca7
test: Split groups managed viewset tests
arthurdedeus Apr 1, 2026
7496e2d
test: Materialize revenue analytics tables in test setup
arthurdedeus Apr 1, 2026
5d45293
fix: Support materialized views in groups revenue analytics join
arthurdedeus Apr 1, 2026
a54fef3
chore: Remove redundant setUp
arthurdedeus Apr 2, 2026
2a2af17
Merge branch 'master' into fix/groups-materialized-view-joins
arthurdedeus Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 8 additions & 51 deletions posthog/hogql/database/schema/groups_revenue_analytics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from collections import defaultdict
from typing import Any, cast

from posthog.schema import DatabaseSchemaManagedViewTableKind

Expand All @@ -12,15 +11,13 @@
LazyJoinToAdd,
LazyTable,
LazyTableToAdd,
SavedQuery,
StringDatabaseField,
)
from posthog.hogql.database.schema.util.revenue_analytics import get_table_kind, is_event_view
from posthog.hogql.errors import ResolutionError

from posthog.models.exchange_rate.sql import EXCHANGE_RATE_DECIMAL_PRECISION

from products.revenue_analytics.backend.views.schemas import SCHEMAS as VIEW_SCHEMAS

ZERO_DECIMAL = ast.Call(
name="toDecimal", args=[ast.Constant(value=0), ast.Constant(value=EXCHANGE_RATE_DECIMAL_PRECISION)]
)
Expand Down Expand Up @@ -56,59 +53,19 @@ def join_with_groups_revenue_analytics_table(
)


def _base_view_args_from_saved_query(saved_query: SavedQuery) -> dict[str, Any]:
return {
"id": saved_query.id,
"query": saved_query.query,
"name": saved_query.name,
"fields": saved_query.fields,
"metadata": saved_query.metadata,
# :KLUDGE: None of these properties below are great but it's all we can do to figure this one out for now
# We'll be able to come up with a better solution we don't need to support the old managed views anymore
"prefix": ".".join(saved_query.name.split(".")[:-1]),
"source_id": None, # Not used so just ignore it
"event_name": saved_query.name.split(".")[2] if "revenue_analytics.events" in saved_query.name else None,
}


def select_from_groups_revenue_analytics_table(context: HogQLContext) -> ast.SelectQuery | ast.SelectSetQuery:
from products.revenue_analytics.backend.views import (
RevenueAnalyticsBaseView,
RevenueAnalyticsCustomerView,
RevenueAnalyticsMRRView,
RevenueAnalyticsRevenueItemView,
)

if not context.database:
return ast.SelectQuery.empty(columns=FIELDS)

customer_schema = VIEW_SCHEMAS[DatabaseSchemaManagedViewTableKind.REVENUE_ANALYTICS_CUSTOMER]
mrr_schema = VIEW_SCHEMAS[DatabaseSchemaManagedViewTableKind.REVENUE_ANALYTICS_MRR]
revenue_item_schema = VIEW_SCHEMAS[DatabaseSchemaManagedViewTableKind.REVENUE_ANALYTICS_REVENUE_ITEM]

# Get all customer/mrr/revenue item tuples from the existing views making sure we ignore `all`
# since the `group` join is in the child view
all_views = defaultdict[str, dict[DatabaseSchemaManagedViewTableKind, RevenueAnalyticsBaseView]](defaultdict)
all_views = defaultdict[str, dict](defaultdict)
for view_name in context.database.get_view_names():
view = cast(SavedQuery | RevenueAnalyticsBaseView, context.database.get_table(view_name))
prefix = ".".join(view_name.split(".")[:-1])

# Might need to convert to RevenueAnalyticsBaseView from a SavedQuery if the FF is enabled
# Soon we'll be able to remove all of this and handle them all using the `SavedQuery` logic directly
if view_name.endswith(customer_schema.source_suffix) or view_name.endswith(customer_schema.events_suffix):
if not isinstance(view, RevenueAnalyticsBaseView):
view = RevenueAnalyticsCustomerView(**_base_view_args_from_saved_query(view))
all_views[prefix][DatabaseSchemaManagedViewTableKind.REVENUE_ANALYTICS_CUSTOMER] = view
elif view_name.endswith(revenue_item_schema.source_suffix) or view_name.endswith(
revenue_item_schema.events_suffix
):
if not isinstance(view, RevenueAnalyticsBaseView):
view = RevenueAnalyticsRevenueItemView(**_base_view_args_from_saved_query(view))
all_views[prefix][DatabaseSchemaManagedViewTableKind.REVENUE_ANALYTICS_REVENUE_ITEM] = view
elif view_name.endswith(mrr_schema.source_suffix) or view_name.endswith(mrr_schema.events_suffix):
if not isinstance(view, RevenueAnalyticsBaseView):
view = RevenueAnalyticsMRRView(**_base_view_args_from_saved_query(view))
all_views[prefix][DatabaseSchemaManagedViewTableKind.REVENUE_ANALYTICS_MRR] = view
table_kind = get_table_kind(view_name)
if table_kind is not None:
view = context.database.get_table(view_name)
prefix = ".".join(view_name.split(".")[:-1])
all_views[prefix][table_kind] = view

# Iterate over all possible view tuples and figure out which queries we can add to the set
queries = []
Expand All @@ -121,7 +78,7 @@ def select_from_groups_revenue_analytics_table(context: HogQLContext) -> ast.Sel
if customer_view is None or revenue_item_view is None or mrr_view is None:
continue

if customer_view.is_event_view():
if is_event_view(customer_view.name):
# For events, group_keys are on each event (group_0_key through group_4_key)
# We aggregate by group_key directly from each source, then FULL OUTER JOIN
# since there's no base entity table to start from
Expand Down
55 changes: 3 additions & 52 deletions posthog/hogql/database/schema/persons_revenue_analytics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from collections import defaultdict
from typing import Literal

from posthog.schema import DatabaseSchemaManagedViewTableKind

Expand All @@ -14,12 +13,11 @@
LazyTableToAdd,
StringDatabaseField,
)
from posthog.hogql.database.schema.util.revenue_analytics import get_table_kind, is_event_view
from posthog.hogql.errors import ResolutionError

from posthog.models.exchange_rate.sql import EXCHANGE_RATE_DECIMAL_PRECISION

from products.revenue_analytics.backend.views.schemas import SCHEMAS as VIEW_SCHEMAS

ZERO_DECIMAL = ast.Call(
name="toDecimal", args=[ast.Constant(value=0), ast.Constant(value=EXCHANGE_RATE_DECIMAL_PRECISION)]
)
Expand All @@ -42,7 +40,7 @@ def _select_from_persons_revenue_analytics_table(context: HogQLContext) -> ast.S
# since the `persons` join is in the child view
all_views = defaultdict[str, dict](defaultdict)
for view_name in context.database.get_view_names():
table_kind = _get_table_kind(view_name)
table_kind = get_table_kind(view_name)
if table_kind is not None:
view = context.database.get_table(view_name)
prefix = ".".join(view_name.split(".")[:-1])
Expand All @@ -62,7 +60,7 @@ def _select_from_persons_revenue_analytics_table(context: HogQLContext) -> ast.S
# If we're working with event views, we can use the customer's id field directly
# Otherwise, we need to join with the persons table by checking whether it exists
person_id_chain: list[str | int] | None = None
if _is_event_view(customer_view.name):
if is_event_view(customer_view.name):
person_id_chain = [RevenueAnalyticsCustomerView.get_generic_view_alias(), "id"]
else:
persons_lazy_join = customer_view.fields.get("persons")
Expand Down Expand Up @@ -159,53 +157,6 @@ def _select_from_persons_revenue_analytics_table(context: HogQLContext) -> ast.S
return ast.SelectSetQuery.create_from_queries(queries, set_operator="UNION ALL")


def _get_table_kind(
view_name: str,
) -> (
Literal[
DatabaseSchemaManagedViewTableKind.REVENUE_ANALYTICS_CUSTOMER,
DatabaseSchemaManagedViewTableKind.REVENUE_ANALYTICS_MRR,
DatabaseSchemaManagedViewTableKind.REVENUE_ANALYTICS_REVENUE_ITEM,
]
| None
):
if _is_customer_schema(view_name=view_name):
return DatabaseSchemaManagedViewTableKind.REVENUE_ANALYTICS_CUSTOMER

if _is_mrr_schema(view_name=view_name):
return DatabaseSchemaManagedViewTableKind.REVENUE_ANALYTICS_MRR

if _is_revenue_item_schema(view_name=view_name):
return DatabaseSchemaManagedViewTableKind.REVENUE_ANALYTICS_REVENUE_ITEM

return None


def _is_customer_schema(view_name: str) -> bool:
customer_schema = VIEW_SCHEMAS[DatabaseSchemaManagedViewTableKind.REVENUE_ANALYTICS_CUSTOMER]
return view_name.endswith(customer_schema.source_suffix) or view_name.endswith(customer_schema.events_suffix)


def _is_mrr_schema(view_name: str) -> bool:
mrr_schema = VIEW_SCHEMAS[DatabaseSchemaManagedViewTableKind.REVENUE_ANALYTICS_MRR]
return view_name.endswith(mrr_schema.source_suffix) or view_name.endswith(mrr_schema.events_suffix)


def _is_revenue_item_schema(view_name: str) -> bool:
revenue_item_schema = VIEW_SCHEMAS[DatabaseSchemaManagedViewTableKind.REVENUE_ANALYTICS_REVENUE_ITEM]
return view_name.endswith(revenue_item_schema.source_suffix) or view_name.endswith(
revenue_item_schema.events_suffix
)


def _is_event_view(view_name: str) -> bool:
return _get_event_name(view_name) is not None


def _get_event_name(view_name: str) -> str | None:
return view_name.split(".")[2] if "revenue_analytics.events" in view_name else None


class PersonsRevenueAnalyticsTable(LazyTable):
fields: dict[str, FieldOrTable] = FIELDS

Expand Down
Loading
Loading