Skip to content

gz-math: init at 9.1.0#401753

Open
Guelakais wants to merge 3 commits into
NixOS:masterfrom
Guelakais:gz-math
Open

gz-math: init at 9.1.0#401753
Guelakais wants to merge 3 commits into
NixOS:masterfrom
Guelakais:gz-math

Conversation

@Guelakais
Copy link
Copy Markdown
Contributor

@Guelakais Guelakais commented Apr 25, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Apr 25, 2025
ethancedwards8
ethancedwards8 suggested changes Apr 26, 2025
View reviewed changes
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
bengsparks
bengsparks suggested changes Apr 26, 2025
View reviewed changes
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
bengsparks
bengsparks suggested changes Apr 30, 2025
View reviewed changes
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
@Guelakais Guelakais force-pushed the gz-math branch 2 times, most recently from 6361eb1 to 2b4c1e6 Compare April 30, 2025 14:46
bengsparks
bengsparks suggested changes May 2, 2025
View reviewed changes
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
bengsparks
bengsparks suggested changes May 2, 2025
View reviewed changes
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
bengsparks
bengsparks suggested changes May 3, 2025
View reviewed changes
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
bengsparks
bengsparks suggested changes May 14, 2025
View reviewed changes
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
@github-actions github-actions Bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 27, 2025
@Guelakais
Copy link
Copy Markdown
Contributor Author

Guelakais commented May 27, 2025

Buildint the default gz-math and the python313Packages.gz-math Package does work now!

@Guelakais Guelakais requested a review from bengsparks May 27, 2025 11:12
@nix-owners nix-owners Bot requested a review from natsukium May 27, 2025 11:13
@github-actions github-actions Bot removed 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 27, 2025
bengsparks
bengsparks suggested changes May 27, 2025
View reviewed changes
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
@Guelakais Guelakais force-pushed the gz-math branch 2 times, most recently from 1445fc9 to 043576d Compare December 6, 2025 15:28
@Guelakais Guelakais changed the title gz-math: init at 8.1.1 gz-math: init at 9.0.0 Dec 6, 2025
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version labels Jan 26, 2026
@nixpkgs-ci nixpkgs-ci Bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Mar 16, 2026
@Guelakais Guelakais mentioned this pull request Apr 18, 2026
Open
19 tasks
taylorhoward92
taylorhoward92 suggested changes Apr 20, 2026
View reviewed changes
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-math/package.nix
Comment thread pkgs/by-name/gz/gz-cmake/package.nix
Comment thread pkgs/by-name/gz/gz-cmake/package.nix
Comment thread pkgs/by-name/gz/gz-cmake/package.nix Outdated
Comment thread pkgs/by-name/gz/gz-cmake/package.nix Outdated
@github-project-automation github-project-automation Bot moved this from 👀 Awaits reviews to 🏗 In progress in ROS 2 Apr 20, 2026
@nixpkgs-ci nixpkgs-ci Bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Apr 29, 2026
@Guelakais Guelakais changed the title gz-math: init at 9.0.0 gz-math: init at 9.1.0 Apr 29, 2026
@Guelakais Guelakais force-pushed the gz-math branch 4 times, most recently from 04cdff1 to 7fe2df2 Compare May 6, 2026 12:01
@SuperSandroBot
Copy link
Copy Markdown

SuperSandroBot commented May 8, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 401753
Commit: 6c427e766563287b9dfb46b99edf05dc50ef5f50 (subsequent changes)
Merge: 8430f7dcab7cc4c6d83297e9cff908ed22c8ad85

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/25528919618

x86_64-linux

✅ 1 package built:
  • gz-math (python313Packages.gz-math, python314Packages.gz-math)

aarch64-linux

✅ 1 package built:
  • gz-math (python313Packages.gz-math, python314Packages.gz-math)

@Guelakais Guelakais requested a review from taylorhoward92 May 13, 2026 12:33
@Guelakais Guelakais force-pushed the gz-math branch 2 times, most recently from aa40fda to 2d96423 Compare May 19, 2026 08:10
@taylorhoward92
Copy link
Copy Markdown
Contributor

taylorhoward92 commented May 19, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401753
Commit: 2d96423616b884a3e5e8ef320d59c4037b434709

x86_64-linux

❌ 2 packages failed to build:
  • gz-math (python313Packages.gz-math, python314Packages.gz-math)
  • gz-utils
✅ 1 package built:
  • gz-cmake

aarch64-linux

✅ 3 packages built:
  • gz-cmake
  • gz-math (python313Packages.gz-math, python314Packages.gz-math)
  • gz-utils
gz-utils 
[----------] 6 tests from Subprocess (393 ms total)

[----------] Global test environment tear-down

[==========] 6 tests from 1 test suite ran. (396 ms total)

[  PASSED  ] 4 tests.

[  FAILED  ] 2 tests, listed below:

[  FAILED  ] Subprocess.CreateInvalid

[  FAILED  ] Subprocess.CreateInvalidSpaces


2 FAILED TESTS


94% tests passed, 1 tests failed out of 17


Total Test time (real) =   0.49 sec


The following tests FAILED:

8 - INTEGRATION_subprocess_TEST (Failed)

Errors while running CTest

make: *** [Makefile:71: test] Error 8

@taylorhoward92
Copy link
Copy Markdown
Contributor

taylorhoward92 commented May 19, 2026

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 401753
Commit: 2d96423616b884a3e5e8ef320d59c4037b434709

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethancedwards8 ethancedwards8 Awaiting requested review from ethancedwards8

@natsukium natsukium Awaiting requested review from natsukium

3 more reviewers

@nim65s nim65s nim65s left review comments

@bengsparks bengsparks bengsparks requested changes

@taylorhoward92 taylorhoward92 taylorhoward92 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

ROS 2
Status: 🏗 In progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@Guelakais @nixos-discourse @SuperSandroBot @taylorhoward92 @nim65s @bengsparks @ethancedwards8 @Amronos