Skip to content

fix(connectors): remove change listener on WalletConnect switchChain failure #5033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tmm merged 2 commits into from
Apr 6, 2026
+9 −6
Merged

fix(connectors): remove change listener on WalletConnect switchChain failure #5033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a540d2
fix(connectors): remove change listener on WalletConnect switchChain …
Zelys-DFKH Mar 24, 2026
1c966a1
chore: up
tmm Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/walletconnect-switchchain-listener-leak.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@wagmi/connectors": patch
---

Fixed listener leak in WalletConnect connector `switchChain` when chain switch fails.
10 changes: 4 additions & 6 deletions packages/connectors/src/walletConnect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,15 +338,12 @@ export function walletConnect(parameters: WalletConnectParameters) {
const chain = config.chains.find((x) => x.id === chainId)
if (!chain) throw new SwitchChainError(new ChainNotConfiguredError())

let listener: (opts: { chainId?: number | undefined }) => void = () => {}
try {
await Promise.all([
new Promise<void>((resolve) => {
const listener = ({
chainId: currentChainId,
}: {
chainId?: number | undefined
}) => {
if (currentChainId === chainId) {
listener = (opts) => {
if (opts.chainId === chainId) {
config.emitter.off('change', listener)
resolve()
}
Expand All @@ -364,6 +361,7 @@ export function walletConnect(parameters: WalletConnectParameters) {

return chain
} catch (err) {
config.emitter.off('change', listener)
const error = err as RpcError

if (/(user rejected)/i.test(error.message))
Expand Down