Conversation
…failure Co-Authored-By: Zelys <noreply@github.com>
|
@Zelys-DFKH is attempting to deploy a commit to the Wevm Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: 1c966a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
195885b to
1c966a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5032
In
walletConnect.ts,switchChainregisters achangelistener on the connector's emitter while waiting forwallet_switchEthereumChainto confirm. When the request fails,Promise.allrejects and control jumps to thecatchblock, but the listener is never removed. Every failed switch attempt (user rejection, network error, wallet timeout) leaves one orphaned listener permanently attached to the emitter.Fixed by storing a cleanup reference before registering the listener and calling it at the top of the
catchblock. Added a test that mocks the provider, fails a switch, and asserts the listener count returns to its pre-call value.