Replace config PluginManager with ConfigManager in many instances#4571
Merged
demiankatz merged 8 commits intoAug 28, 2025
Merged
Conversation
demiankatz
requested changes
Aug 27, 2025
demiankatz
added
the
architecture
demiankatz
reviewed
Aug 27, 2025
demiankatz
reviewed
Aug 27, 2025
demiankatz
reviewed
Aug 27, 2025
demiankatz
reviewed
Aug 27, 2025
demiankatz
reviewed
Aug 27, 2025
demiankatz
reviewed
Aug 27, 2025
demiankatz
reviewed
Aug 27, 2025
demiankatz
reviewed
Aug 27, 2025
demiankatz
requested changes
Aug 28, 2025
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @ThoWagen -- see a few new observations below.
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
demiankatz
approved these changes
Aug 28, 2025
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
This all looks good to me now, and tests are passing. Thanks, @ThoWagen!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the config PluginManager with the ConfigManager in many instances as a fist step in getting rid of the PluginManager completely.
It is probably better to wait until #4570 is merged, before this is merged. Otherwise, there will be no caching for the instances changed in this PR.