Add cache to ConfigManager#4570
Merged
demiankatz merged 3 commits intoAug 28, 2025
Merged
Conversation
demiankatz
requested changes
Aug 27, 2025
Member
demiankatz
left a comment
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @ThoWagen, this looks pretty good to me, but see below for a few minor suggestions and one potentially more significant one.
demiankatz
added
the
architecture
Co-authored-by: Demian Katz <demian.katz@villanova.edu>
demiankatz
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds caching to the ConfigManager and also adds the
useLocalConfigparameter to thegetConfigmethod in preparation to move loading of YAML files to it.