Update index.js, test.js, and languages.js to add functionality from multiple unmerged PRs from the unmaintained upstream as well as clean up the code a bit#15
Closed
rawr51919 wants to merge 9 commits into
Conversation
Updates index.js to fix translations over 2083 characters (carryover from unmaintained upstream PR matheuss#13).
Updates test.js to add the test case in from matheuss#13 and merge in the tweaks from #12
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 92.42% 93.05% +0.63%
==========================================
Files 2 2
Lines 66 72 +6
==========================================
+ Hits 61 67 +6
Misses 5 5
Continue to review full report at Codecov.
|
rawr51919
changed the title
Add newline to enhance readability
rawr51919
changed the title
rawr51919
changed the title
Updates index.js to add in content from more unmerged PRs to the unmaintained upstream.
Updates languages.js to add content from unmerged PRs to the unmaintained upstream where possible.
Fix a minor error in the index.js keeping the Travis CI build from passing.
Updates test.js to add test cases from unmerged PRs to the unmaintained upstream.
Updates the test.js to fix a minor typo in one of the test cases.
Updates index.js to fix Travis CI builds.
rawr51919
changed the title
Owner
|
@coltongit Thanks a lot! Could you please split on different PRs: one pr - one purpose. |
Author
|
I'll reopen #12 as part of that and get separate PRs going to show exactly which one goes to which PR. Every change featured here would warrant a v2.9.0 just due to how much has happened here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates index.js, test.js, and languages.js to expose the individual languages in the API, allow for translations over 2083 characters in length, make the language names match Google Translate, and add numerous test cases adding in their functionalities (carryovers from unmaintained upstream PRs matheuss#13, matheuss#30, matheuss#31, and matheuss#61). This also merges the test.js contents with the contents of the test.js from PR #12 to avoid conflicts.