Update test.js to remove the test scenario where the API tries to translate without internet#12
Conversation
Add a test scenario to attempt the translation of text without an internet connection as this was in the todo list codewise (it's meant to always fail, but that part of it has yet to be coded).
rawr51919
changed the title
|
Frankly speaking I don't see any profit from this test. I suggest just to remove it. |
|
Considering that it isn't easy to simulate the loss of an internet connection in JavaScript, this test case has to be removed. This has been done in the latest commit. |
Updates test.js to remove the 'try to translate text without an internet connection' test.
rawr51919
changed the title
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
=======================================
Coverage 92.42% 92.42%
=======================================
Files 2 2
Lines 66 66
=======================================
Hits 61 61
Misses 5 5Continue to review full report at Codecov.
|
Add back the newlines.
Remove unnecessary indents in the newlines.
|
Not only did I add them back in, but I also added others to make it easier to read than it was beforehand. |
|
Not only have the changes from this PR been moved to PR #15, but that PR also addresses an issue that had been previously resolved in the unmaintained upstream, but was never merged. Due to this, this PR is hereby closed. |
|
Reopening as part of the separation requested in PR #15. |
3 participants
Add a test scenario to attempt the translation of text without an internet connection as this was in the todo list codewise (it's meant to always fail, but that part of it has yet to be coded).This has been removed as there's not much use to this test case anyway.