Document UploadImageToDatasets on the data manager service#5193
Open
btshrewsbury-viam wants to merge 1 commit into
Open
Document UploadImageToDatasets on the data manager service#5193btshrewsbury-viam wants to merge 1 commit into
btshrewsbury-viam wants to merge 1 commit into
Conversation
The Go SDK's data manager service gained UploadImageToDatasets (rdk#5145, DATA-4320) alongside the already-documented UploadBinaryDataToDatasets, but it was missing from the API reference and flagged by the SDK method coverage job. Adds the CSV row, rewords the pre-staged proto description override to imperative table style, and regenerates the data manager markdown. Refs #5142.
Collaborator
Author
|
gloriacai01 Could you please review this PR? Looks like UploadImageToDatasets was missing for some reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this adds
The Go SDK's data manager service gained UploadImageToDatasets (rdk#5145, DATA-4320) alongside the already-documented
UploadBinaryDataToDatasets, but it was missing from the data manager API reference and flagged by the weekly SDK method coverage job (#5142).One CSV row, one proto description override (rewording the pre-staged file to the imperative style the method tables use), and the regenerated data manager markdown.
Split out of #5187 so this can be reviewed independently of the fleet-page methods — the two share no generated files.
Merge order
Stacked on #5184 because both regenerate the data manager markdown. Merge #5184 first; GitHub retargets this automatically. Refs #5142 but does not close it (remaining warnings tracked in #5188/#5189/#5190).
Verification
Targeted coverage run: the warning cleared, no missing-override warnings, links verified against the current /reference/apis/ paths.
Refs #5142