Merged
Conversation
nextjs-bot
added
created-by: Turbopack team
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 6, 2026
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
This was referenced Apr 6, 2026
Member
|
I remember @timneutkens investigating this some time ago as well. There was some Vite/Vitest blog post about this how they made their tool faster by dropping this name set call. |
Contributor
Author
|
yeah i was wondering about that. sigh... i can drop this, but perhaps a 10ms hit is acceptible? or i could do it in a worker_thread 😆 |
bgw
approved these changes
Apr 7, 2026
Member
|
IMO this amount of overhead doesn't really matter for Maybe just leave a note that this isn't super critical and can be removed if it turns out that the performance cost is noticeable? |
eps1lon
approved these changes
Apr 7, 2026
Member
|
Yeah it's about 10ms. Not a big deal for this case. For dev it was in the hot path for logging bootup time. |
eps1lon
pushed a commit
that referenced
this pull request
Apr 7, 2026
When `next dev` is running we change the process name, we should do the same thing for builds. This is a small performance hit on MacOs, about 10ms, (See node issue: nodejs/node#59678), but not on other platforms. `process.title` is also apparently not implemented on `Bun` or `Deno` 🤦
eps1lon
pushed a commit
that referenced
this pull request
Apr 7, 2026
When `next dev` is running we change the process name, we should do the same thing for builds. This is a small performance hit on MacOs, about 10ms, (See node issue: nodejs/node#59678), but not on other platforms. `process.title` is also apparently not implemented on `Bun` or `Deno` 🤦
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
next devis running we change the process name, we should do the same thing for builds.This is a small performance hit on MacOs, about 10ms, (See node issue: nodejs/node#59678), but not on other platforms.
process.titleis also apparently not implemented onBunorDeno🤦