simplify session dependent tasks (#91729)#92358
Draft
lukesandberg wants to merge 1 commit intocanaryfrom
Draft
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 4, 2026
Merging this PR will not alter performance
Comparing Footnotes
|
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles
Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
ec9f7f3 to
2be529b
Compare
f5f9dc0 to
0cae08f
Compare
This was referenced Apr 6, 2026
0cae08f to
70da271
Compare
2be529b to
2bc6c08
Compare
70da271 to
781db31
Compare
2bc6c08 to
76294c3
Compare
This was referenced Apr 6, 2026
76294c3 to
632c22b
Compare
0522d66 to
00769ef
Compare
c275d99 to
806bd09
Compare
00769ef to
a550e51
Compare
a550e51 to
c7c7689
Compare
806bd09 to
21c28c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This is a re-application of #91729 without the TTL support (fetch
Cache-ControlandTransientStatechanges are excluded).Make
session_dependenta function attributePreviously, tasks called
mark_session_dependent()at runtime to flag themselves. This PR makes it a compile-time#[turbo_tasks::function(session_dependent)]attribute instead. Benefits:mark_session_dependent()call needed — the attribute is declarative and statically checked.mark_session_dependent(),mark_own_task_as_session_dependent(), and thesession_dependentfield fromInProgressStateInner. The backend now readsis_session_dependentdirectly from theNativeFunctionmetadata viaTaskGuard::is_session_dependent().Test Plan
cargo check -p turbo-tasks -p turbo-tasks-backend -p turbo-tasks-fetchCloses NEXT-