Skip to content

fix: ensure test files are ignored when type checking #92409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
donkeyote wants to merge 1 commit into
base: canary
Choose a base branch
from
+12 −11
Open

fix: ensure test files are ignored when type checking #92409

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions packages/next/src/lib/typescript/runTypeCheck.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,18 @@ export async function runTypeCheck(
})
}

const ignoreRegex = [
// matches **/__(tests|mocks)__/**
/[\\/]__(?:tests|mocks)__[\\/]/,
// matches **/*.(spec|test).*
/(?<=[\\/.])(?:spec|test)\.[^\\/]+$/,
]
const regexIgnoredFile = new RegExp(
ignoreRegex.map((r) => r.source).join('|')
)

fileNames = fileNames.filter((fileName) => !regexIgnoredFile.test(fileName))

if (fileNames.length < 1) {
return {
hasWarnings: false,
Expand Down Expand Up @@ -150,20 +162,9 @@ export async function runTypeCheck(

const result = program.emit()

const ignoreRegex = [
// matches **/__(tests|mocks)__/**
/[\\/]__(?:tests|mocks)__[\\/]/,
// matches **/*.(spec|test).*
/(?<=[\\/.])(?:spec|test)\.[^\\/]+$/,
]
const regexIgnoredFile = new RegExp(
ignoreRegex.map((r) => r.source).join('|')
)

const allDiagnostics = typescript
.getPreEmitDiagnostics(program as import('typescript').Program)
.concat(result.diagnostics)
.filter((d) => !(d.file && regexIgnoredFile.test(d.file.fileName)))

const firstError =
allDiagnostics.find(
Expand Down
Loading