fix: ensure test files are ignored when type checking#92409
Open
donkeyote wants to merge 1 commit intovercel:canaryfrom
Open
fix: ensure test files are ignored when type checking#92409donkeyote wants to merge 1 commit intovercel:canaryfrom
donkeyote wants to merge 1 commit intovercel:canaryfrom
Conversation
Move test file exclusion filter to run before the TypeScript program is created, rather than filtering diagnostics after the emit. Previously, test and mock files (__tests__, __mocks__, *.spec.*, *.test.*) were still compiled as part of the program — their errors were just suppressed. Now they are excluded from rootNames upfront, so they are never type-checked at all.
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92408
Move test file exclusion filter to run before the TypeScript program is created, rather than filtering diagnostics after the emit.
Previously, test and mock files (tests, mocks, .spec., .test.) were still compiled as part of the program — their errors were just suppressed. Now they are excluded from rootNames upfront, so they are never type-checked at all.