Skip to content

Reapply "simplify session dependent tasks and add TTL support (#91729)"#92321

Closed
lukesandberg wants to merge 2 commits intocanaryfrom
re_apply_session_dependent_tasks
Closed

Reapply "simplify session dependent tasks and add TTL support (#91729)"#92321
lukesandberg wants to merge 2 commits intocanaryfrom
re_apply_session_dependent_tasks

Conversation

@lukesandberg
Copy link
Copy Markdown
Contributor

No description provided.

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Apr 3, 2026
Copy link
Copy Markdown
Contributor Author

lukesandberg commented Apr 3, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 3, 2026

Merging this PR will not alter performance

✅ 9 untouched benchmarks
⏩ 11 skipped benchmarks1


Comparing re_apply_session_dependent_tasks (a88b102) with canary (6160d0d)

Open in CodSpeed

Footnotes

  1. 11 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@lukesandberg lukesandberg changed the base branch from revert_session_dependent_tasks_change to graphite-base/92321 April 3, 2026 21:46
@lukesandberg lukesandberg force-pushed the graphite-base/92321 branch from 4a6d432 to 6160d0d Compare April 3, 2026 21:46
@lukesandberg lukesandberg force-pushed the re_apply_session_dependent_tasks branch from 14942e6 to c338444 Compare April 3, 2026 21:46
@graphite-app graphite-app bot changed the base branch from graphite-base/92321 to canary April 3, 2026 21:47
@lukesandberg lukesandberg force-pushed the re_apply_session_dependent_tasks branch from c338444 to a88b102 Compare April 3, 2026 21:47
@nextjs-bot
Copy link
Copy Markdown
Collaborator

Failing test suites

Commit: a88b102 | About building and testing Next.js

pnpm test-dev-turbo test/development/app-dir/edge-errors-hmr/index.test.ts (turbopack) (job)

  • develop - app-dir - edge errros hmr > should recover from build errors when server component error (DD)
Expand output

● develop - app-dir - edge errros hmr › should recover from build errors when server component error

Expected no visible Redbox but found one
header: Runtime Error
./app/comp.server.js:9:5
Expression expected
   7 |       {/* Uncomment the following line and save file to see the error: */}
   8 |       <
>  9 |     </div>
     |     ^
  10 |   )
  11 | }
  12 |

Parsing ecmascript source code failed

Import trace:
  Edge Server Component:
    ./app/comp.server.js
    ./app/page.js
Show More
description: ./app/comp.server.js:9:5
Expression expected
   7 |       {/* Uncomment the following line and save file to see the error: */}
   8 |       <
>  9 |     </div>
     |     ^
  10 |   )
  11 | }
  12 |

Parsing ecmascript source code failed

Import trace:
  Edge Server Component:
    ./app/comp.server.js
    ./app/page.js
source: null

  19 |     await next.patchFile('app/comp.server.js', clientComponentSource)
  20 |
> 21 |     await waitForNoRedbox(browser)
     |     ^
  22 |   })
  23 |
  24 |   it('should recover from build errors when client component error', async () => {

  at Object.<anonymous> (development/app-dir/edge-errors-hmr/index.test.ts:21:5)

@nextjs-bot
Copy link
Copy Markdown
Collaborator

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ▁▁█▁▁
Cold (Ready in log) 433ms 433ms ▁▁█▁▁
Cold (First Request) 1.085s 1.072s ▂▂█▂▂
Warm (Listen) 456ms 455ms ▁▁█▁▁
Warm (Ready in log) 439ms 438ms ▁▁█▁▁
Warm (First Request) 334ms 332ms ▁▁█▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 456ms ▁▁▁▁▁
Cold (Ready in log) 433ms 432ms ▁▁▁▁▁
Cold (First Request) 1.832s 1.850s ▂▂▁▁▁
Warm (Listen) 456ms 456ms ▁▁▁▁▁
Warm (Ready in log) 432ms 432ms ▁▁▁▁▁
Warm (First Request) 1.858s 1.853s ▃▂▂▂▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.733s 3.843s ▁▁█▁▁
Cached Build 3.778s 3.787s ▁▁█▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.264s 14.364s ▁▁▁▁▁
Cached Build 14.401s 14.493s ▁▁▁▁▁
node_modules Size 487 MB 487 MB ▁▁▁██
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
0_46ugbwv6j5u.js gzip 157 B N/A -
02fkg8wfh0iju.js gzip 9.19 kB N/A -
050zwt5xh_0tx.js gzip 10.4 kB N/A -
06rvbj82bhyo0.js gzip 13 kB N/A -
087fzjd-gvlzv.js gzip 450 B N/A -
0c8eee7vsfvhg.js gzip 158 B N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB
0hf-t_s6tbgz-.js gzip 169 B N/A -
0iq926m0x-r3-.js gzip 153 B N/A -
0ppxcl_z43mad.js gzip 8.52 kB N/A -
0wtma0mh35z_y.js gzip 160 B N/A -
19oha6-znmkcv.js gzip 8.55 kB N/A -
1elt1qium-r2m.css gzip 115 B 115 B
1udcfz5hedxcw.js gzip 158 B N/A -
1ujisbsul70qr.js gzip 156 B N/A -
2_0ucn6wszlx_.js gzip 155 B N/A -
2_5rjb7lqxntf.js gzip 221 B 221 B
219prxwxgaalc.js gzip 7.61 kB N/A -
26elcgxnn9zjd.js gzip 8.52 kB N/A -
2900hudr6gvm0.js gzip 2.28 kB N/A -
2j6j9bxrbjzs5.js gzip 156 B N/A -
2lv2js3kmdeho.js gzip 8.48 kB N/A -
2rehygrd36hqv.js gzip 8.58 kB N/A -
2srwswih0m9_h.js gzip 13.3 kB N/A -
3-p9p9mheqhzx.js gzip 8.55 kB N/A -
31030bryqpolg.js gzip 8.53 kB N/A -
31dx5nmrzzuy7.js gzip 225 B N/A -
320_hehl4a3pv.js gzip 156 B N/A -
3925v09gtu-5k.js gzip 49 kB N/A -
39uvrup6ifo7x.js gzip 157 B N/A -
39x4zj5mjb4d_.js gzip 9.77 kB N/A -
3cypnk7-ef9r9.js gzip 155 B N/A -
3k-48b78ys_vy.js gzip 10.1 kB N/A -
3m7-5rfj0avoz.js gzip 12.9 kB N/A -
3mvv_h4ju972c.js gzip 162 B N/A -
3n48wew_9lrou.js gzip 65.7 kB N/A -
3sun1bg5hc6y0.js gzip 70.8 kB N/A -
3uqce_6sa526g.js gzip 8.47 kB N/A -
3yurjqk-sjs3y.js gzip 1.46 kB N/A -
40ybjx9c192n0.js gzip 13.8 kB N/A -
421vzwdt9j1b_.js gzip 5.62 kB N/A -
turbopack-0m..3wm0.js gzip 4.18 kB N/A -
turbopack-0o..wcdw.js gzip 4.17 kB N/A -
turbopack-0t..jedg.js gzip 4.18 kB N/A -
turbopack-1h..rue5.js gzip 4.18 kB N/A -
turbopack-1i..9hg1.js gzip 4.17 kB N/A -
turbopack-1k..b0nc.js gzip 4.18 kB N/A -
turbopack-2q..o805.js gzip 4.18 kB N/A -
turbopack-2w..6w0r.js gzip 4.17 kB N/A -
turbopack-3_..8r4r.js gzip 4.18 kB N/A -
turbopack-33..j1jw.js gzip 4.18 kB N/A -
turbopack-3f..wi18.js gzip 4.17 kB N/A -
turbopack-3m..ch_f.js gzip 4.18 kB N/A -
turbopack-3o..hcxh.js gzip 4.16 kB N/A -
turbopack-44..347w.js gzip 4.19 kB N/A -
03dgzoo-qf3sm.js gzip N/A 9.19 kB -
05tx5f25dlivn.js gzip N/A 8.53 kB -
098yzlv_zeldy.js gzip N/A 156 B -
0ac6eadu_xzp0.js gzip N/A 155 B -
0bc6dn5gcc02s.js gzip N/A 65.7 kB -
0c7ez6p2qc57f.js gzip N/A 5.62 kB -
0duvj3qk5pvgn.js gzip N/A 13.8 kB -
0hg-56wbe76y8.js gzip N/A 154 B -
0m-34rm9w_wpm.js gzip N/A 7.6 kB -
0qnwuk92m8i7o.js gzip N/A 10.4 kB -
0r4wrn6n0ue2m.js gzip N/A 8.55 kB -
0rp0fodtbt_6m.js gzip N/A 8.52 kB -
0sfck-km4dl1k.js gzip N/A 8.47 kB -
0x0xuhmxzwkp8.js gzip N/A 8.47 kB -
1-wdvgxnzicj7.js gzip N/A 1.46 kB -
11u6nxujb2eg4.js gzip N/A 450 B -
1jv-o1_s-zmua.js gzip N/A 49 kB -
1lydcroabuo9f.js gzip N/A 160 B -
1t67fic-dgpnc.js gzip N/A 154 B -
28jckxmrjl7z5.js gzip N/A 70.8 kB -
2couoqe89ztja.js gzip N/A 157 B -
2k9ax08cjl2id.js gzip N/A 12.9 kB -
2lms6k76q5-6m.js gzip N/A 13.3 kB -
2qg4g7l8jgiyw.js gzip N/A 157 B -
2qx4twi9i3xus.js gzip N/A 2.28 kB -
2s48ia9oal47z.js gzip N/A 167 B -
2srnqic6tvxxd.js gzip N/A 8.52 kB -
2trjt1w4kc5dx.js gzip N/A 155 B -
2y7c84piyad79.js gzip N/A 157 B -
30l7m4nayp73a.js gzip N/A 8.55 kB -
38rr7d3kfutni.js gzip N/A 13 kB -
3h_ecpiaatwgc.js gzip N/A 10.1 kB -
3hg2zv7-1d1t7.js gzip N/A 153 B -
3ity0aahajapd.js gzip N/A 225 B -
3j6cr0m_83pgy.js gzip N/A 159 B -
3vg-_o7s6cjyo.js gzip N/A 157 B -
3wrhpuc-j1aw9.js gzip N/A 9.77 kB -
43mlw9dy_8f02.js gzip N/A 8.58 kB -
turbopack-0-..mjxl.js gzip N/A 4.18 kB -
turbopack-02..h7q1.js gzip N/A 4.17 kB -
turbopack-06..lph_.js gzip N/A 4.18 kB -
turbopack-0a..9hzd.js gzip N/A 4.17 kB -
turbopack-0w..vxu4.js gzip N/A 4.17 kB -
turbopack-14..6f1m.js gzip N/A 4.18 kB -
turbopack-17..5tfp.js gzip N/A 4.18 kB -
turbopack-1w..1ikx.js gzip N/A 4.17 kB -
turbopack-2j..fto6.js gzip N/A 4.16 kB -
turbopack-2o..67vd.js gzip N/A 4.18 kB -
turbopack-2w..m6_u.js gzip N/A 4.18 kB -
turbopack-3i..r7ui.js gzip N/A 4.17 kB -
turbopack-3k..8rm1.js gzip N/A 4.18 kB -
turbopack-40..we0n.js gzip N/A 4.19 kB -
Total 464 kB 464 kB ✅ -30 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 717 B 716 B
Total 717 B 716 B ✅ -1 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 433 B 435 B
Total 433 B 435 B ⚠️ +2 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 60.7 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.8 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB
main-app-HASH.js gzip 256 B 254 B
main-HASH.js gzip 39.3 kB 39.2 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.8 kB -
9544-HASH.js gzip N/A 61.4 kB -
Total 235 kB 235 kB ⚠️ +648 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B
dynamic-HASH.js gzip 1.81 kB 1.81 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 351 B 352 B
hooks-HASH.js gzip 384 B 383 B
image-HASH.js gzip 580 B 581 B
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 2.51 kB 2.51 kB
routerDirect..HASH.js gzip 320 B 319 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 315 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 126 kB
page.js gzip 273 kB 273 kB
Total 398 kB 398 kB ⚠️ +172 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 618 B 615 B
middleware-r..fest.js gzip 156 B 155 B
middleware.js gzip 44 kB 44.5 kB 🔴 +488 B (+1%)
edge-runtime..pack.js gzip 842 B 842 B
Total 45.6 kB 46.1 kB ⚠️ +484 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.37 MB 4.37 MB 🟢 8.32 kB (0%)
index.pack gzip 115 kB 114 kB 🟢 1.18 kB (-1%)
index.pack.old gzip 115 kB 114 kB 🟢 1.46 kB (-1%)
Total 4.6 MB 4.59 MB ✅ -11 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 342 kB 342 kB
app-page-exp..prod.js gzip 189 kB 189 kB
app-page-tur...dev.js gzip 341 kB 341 kB
app-page-tur..prod.js gzip 189 kB 189 kB
app-page-tur...dev.js gzip 338 kB 338 kB
app-page-tur..prod.js gzip 187 kB 187 kB
app-page.run...dev.js gzip 338 kB 338 kB
app-page.run..prod.js gzip 187 kB 187 kB
app-route-ex...dev.js gzip 76.6 kB 76.6 kB
app-route-ex..prod.js gzip 52.2 kB 52.2 kB
app-route-tu...dev.js gzip 76.6 kB 76.6 kB
app-route-tu..prod.js gzip 52.2 kB 52.2 kB
app-route-tu...dev.js gzip 76.2 kB 76.2 kB
app-route-tu..prod.js gzip 52 kB 52 kB
app-route.ru...dev.js gzip 76.2 kB 76.2 kB
app-route.ru..prod.js gzip 52 kB 52 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 43.8 kB 43.8 kB
pages-api-tu..prod.js gzip 33.4 kB 33.4 kB
pages-api.ru...dev.js gzip 43.8 kB 43.8 kB
pages-api.ru..prod.js gzip 33.4 kB 33.4 kB
pages-turbo....dev.js gzip 53.2 kB 53.2 kB
pages-turbo...prod.js gzip 39 kB 39 kB
pages.runtim...dev.js gzip 53.2 kB 53.2 kB
pages.runtim..prod.js gzip 39 kB 39 kB
server.runti..prod.js gzip 62.8 kB 62.8 kB
Total 3.03 MB 3.03 MB ⚠️ +4 B
📎 Tarball URL
https://vercel-packages.vercel.app/next/commits/a88b102e3ecdc6f2c6fc2a72d5a1bd2cb0d92f70/next

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants