Skip to content

Revert "simplify session dependent tasks and add TTL support (#91729)"#92320

Merged
lukesandberg merged 1 commit intocanaryfrom
revert_session_dependent_tasks_change
Apr 3, 2026
Merged

Revert "simplify session dependent tasks and add TTL support (#91729)"#92320
lukesandberg merged 1 commit intocanaryfrom
revert_session_dependent_tasks_change

Conversation

@lukesandberg
Copy link
Copy Markdown
Contributor

@lukesandberg lukesandberg commented Apr 3, 2026

This is causing OOMs in some applications running with a persistent cache

See discussion: https://vercel.slack.com/archives/C03EWR7LGEN/p1775159630054759

The issue appears to be invalidating the chunk graph in an odd way that causes us to allocate an ~infinite number of error strings

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Apr 3, 2026
Copy link
Copy Markdown
Contributor Author

lukesandberg commented Apr 3, 2026

@lukesandberg lukesandberg force-pushed the revert_session_dependent_tasks_change branch from b331c6a to 4a6d432 Compare April 3, 2026 18:30
@lukesandberg lukesandberg marked this pull request as ready for review April 3, 2026 18:30
@lukesandberg lukesandberg requested review from a team and sokra April 3, 2026 18:30
@nextjs-bot
Copy link
Copy Markdown
Collaborator

nextjs-bot commented Apr 3, 2026

Tests Passed

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Apr 3, 2026

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing revert_session_dependent_tasks_change (4a6d432) with canary (9cb2048)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@nextjs-bot
Copy link
Copy Markdown
Collaborator

nextjs-bot commented Apr 3, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ▁▁▁▁█
Cold (Ready in log) 436ms 438ms ▁▁▁▁█
Cold (First Request) 1.118s 1.100s ▂▁▂▂█
Warm (Listen) 456ms 456ms ▁▁▁▁█
Warm (Ready in log) 441ms 441ms ▁▁▁▁█
Warm (First Request) 355ms 346ms ▁▁▁▁█

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.802s 3.811s ▁▁▁▁█
Cached Build 3.898s 3.852s ▁▁▁▁█
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
node_modules Size 487 MB 487 MB ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles
Canary PR Change
0_46ugbwv6j5u.js gzip 157 B N/A -
02fkg8wfh0iju.js gzip 9.19 kB N/A -
050zwt5xh_0tx.js gzip 10.4 kB N/A -
06rvbj82bhyo0.js gzip 13 kB N/A -
087fzjd-gvlzv.js gzip 450 B N/A -
0c8eee7vsfvhg.js gzip 158 B N/A -
0cz1d0mv5g_q7.js gzip 39.4 kB 39.4 kB
0hf-t_s6tbgz-.js gzip 169 B N/A -
0iq926m0x-r3-.js gzip 153 B N/A -
0ppxcl_z43mad.js gzip 8.52 kB N/A -
0wtma0mh35z_y.js gzip 160 B N/A -
19oha6-znmkcv.js gzip 8.55 kB N/A -
1elt1qium-r2m.css gzip 115 B 115 B
1udcfz5hedxcw.js gzip 158 B N/A -
1ujisbsul70qr.js gzip 156 B N/A -
2_0ucn6wszlx_.js gzip 155 B N/A -
2_5rjb7lqxntf.js gzip 221 B 221 B
219prxwxgaalc.js gzip 7.61 kB N/A -
26elcgxnn9zjd.js gzip 8.52 kB N/A -
2900hudr6gvm0.js gzip 2.28 kB N/A -
2j6j9bxrbjzs5.js gzip 156 B N/A -
2lv2js3kmdeho.js gzip 8.48 kB N/A -
2rehygrd36hqv.js gzip 8.58 kB N/A -
2srwswih0m9_h.js gzip 13.3 kB N/A -
3-p9p9mheqhzx.js gzip 8.55 kB N/A -
31030bryqpolg.js gzip 8.53 kB N/A -
31dx5nmrzzuy7.js gzip 225 B N/A -
320_hehl4a3pv.js gzip 156 B N/A -
3925v09gtu-5k.js gzip 49 kB N/A -
39uvrup6ifo7x.js gzip 157 B N/A -
39x4zj5mjb4d_.js gzip 9.77 kB N/A -
3cypnk7-ef9r9.js gzip 155 B N/A -
3k-48b78ys_vy.js gzip 10.1 kB N/A -
3m7-5rfj0avoz.js gzip 12.9 kB N/A -
3mvv_h4ju972c.js gzip 162 B N/A -
3n48wew_9lrou.js gzip 65.7 kB N/A -
3sun1bg5hc6y0.js gzip 70.8 kB N/A -
3uqce_6sa526g.js gzip 8.47 kB N/A -
3yurjqk-sjs3y.js gzip 1.46 kB N/A -
40ybjx9c192n0.js gzip 13.8 kB N/A -
421vzwdt9j1b_.js gzip 5.62 kB N/A -
turbopack-0m..3wm0.js gzip 4.18 kB N/A -
turbopack-0o..wcdw.js gzip 4.17 kB N/A -
turbopack-0t..jedg.js gzip 4.18 kB N/A -
turbopack-1h..rue5.js gzip 4.18 kB N/A -
turbopack-1i..9hg1.js gzip 4.17 kB N/A -
turbopack-1k..b0nc.js gzip 4.18 kB N/A -
turbopack-2q..o805.js gzip 4.18 kB N/A -
turbopack-2w..6w0r.js gzip 4.17 kB N/A -
turbopack-3_..8r4r.js gzip 4.18 kB N/A -
turbopack-33..j1jw.js gzip 4.18 kB N/A -
turbopack-3f..wi18.js gzip 4.17 kB N/A -
turbopack-3m..ch_f.js gzip 4.18 kB N/A -
turbopack-3o..hcxh.js gzip 4.16 kB N/A -
turbopack-44..347w.js gzip 4.19 kB N/A -
03dgzoo-qf3sm.js gzip N/A 9.19 kB -
05tx5f25dlivn.js gzip N/A 8.53 kB -
098yzlv_zeldy.js gzip N/A 156 B -
0ac6eadu_xzp0.js gzip N/A 155 B -
0bc6dn5gcc02s.js gzip N/A 65.7 kB -
0c7ez6p2qc57f.js gzip N/A 5.62 kB -
0duvj3qk5pvgn.js gzip N/A 13.8 kB -
0hg-56wbe76y8.js gzip N/A 154 B -
0m-34rm9w_wpm.js gzip N/A 7.6 kB -
0qnwuk92m8i7o.js gzip N/A 10.4 kB -
0r4wrn6n0ue2m.js gzip N/A 8.55 kB -
0rp0fodtbt_6m.js gzip N/A 8.52 kB -
0sfck-km4dl1k.js gzip N/A 8.47 kB -
0x0xuhmxzwkp8.js gzip N/A 8.47 kB -
1-wdvgxnzicj7.js gzip N/A 1.46 kB -
11u6nxujb2eg4.js gzip N/A 450 B -
1jv-o1_s-zmua.js gzip N/A 49 kB -
1lydcroabuo9f.js gzip N/A 160 B -
1t67fic-dgpnc.js gzip N/A 154 B -
28jckxmrjl7z5.js gzip N/A 70.8 kB -
2couoqe89ztja.js gzip N/A 157 B -
2k9ax08cjl2id.js gzip N/A 12.9 kB -
2lms6k76q5-6m.js gzip N/A 13.3 kB -
2qg4g7l8jgiyw.js gzip N/A 157 B -
2qx4twi9i3xus.js gzip N/A 2.28 kB -
2s48ia9oal47z.js gzip N/A 167 B -
2srnqic6tvxxd.js gzip N/A 8.52 kB -
2trjt1w4kc5dx.js gzip N/A 155 B -
2y7c84piyad79.js gzip N/A 157 B -
30l7m4nayp73a.js gzip N/A 8.55 kB -
38rr7d3kfutni.js gzip N/A 13 kB -
3h_ecpiaatwgc.js gzip N/A 10.1 kB -
3hg2zv7-1d1t7.js gzip N/A 153 B -
3ity0aahajapd.js gzip N/A 225 B -
3j6cr0m_83pgy.js gzip N/A 159 B -
3vg-_o7s6cjyo.js gzip N/A 157 B -
3wrhpuc-j1aw9.js gzip N/A 9.77 kB -
43mlw9dy_8f02.js gzip N/A 8.58 kB -
turbopack-0-..mjxl.js gzip N/A 4.18 kB -
turbopack-02..h7q1.js gzip N/A 4.17 kB -
turbopack-06..lph_.js gzip N/A 4.18 kB -
turbopack-0a..9hzd.js gzip N/A 4.17 kB -
turbopack-0w..vxu4.js gzip N/A 4.17 kB -
turbopack-14..6f1m.js gzip N/A 4.18 kB -
turbopack-17..5tfp.js gzip N/A 4.18 kB -
turbopack-1w..1ikx.js gzip N/A 4.17 kB -
turbopack-2j..fto6.js gzip N/A 4.16 kB -
turbopack-2o..67vd.js gzip N/A 4.18 kB -
turbopack-2w..m6_u.js gzip N/A 4.18 kB -
turbopack-3i..r7ui.js gzip N/A 4.17 kB -
turbopack-3k..8rm1.js gzip N/A 4.18 kB -
turbopack-40..we0n.js gzip N/A 4.19 kB -
Total 464 kB 464 kB ✅ -30 B

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 717 B 716 B
Total 717 B 716 B ✅ -1 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 433 B 435 B
Total 433 B 435 B ⚠️ +2 B

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 342 kB 342 kB
app-page-exp..prod.js gzip 189 kB 189 kB
app-page-tur...dev.js gzip 341 kB 341 kB
app-page-tur..prod.js gzip 189 kB 189 kB
app-page-tur...dev.js gzip 338 kB 338 kB
app-page-tur..prod.js gzip 187 kB 187 kB
app-page.run...dev.js gzip 338 kB 338 kB
app-page.run..prod.js gzip 187 kB 187 kB
app-route-ex...dev.js gzip 76.6 kB 76.6 kB
app-route-ex..prod.js gzip 52.2 kB 52.2 kB
app-route-tu...dev.js gzip 76.6 kB 76.6 kB
app-route-tu..prod.js gzip 52.2 kB 52.2 kB
app-route-tu...dev.js gzip 76.2 kB 76.2 kB
app-route-tu..prod.js gzip 52 kB 52 kB
app-route.ru...dev.js gzip 76.2 kB 76.2 kB
app-route.ru..prod.js gzip 52 kB 52 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 43.8 kB 43.8 kB
pages-api-tu..prod.js gzip 33.4 kB 33.4 kB
pages-api.ru...dev.js gzip 43.8 kB 43.8 kB
pages-api.ru..prod.js gzip 33.4 kB 33.4 kB
pages-turbo....dev.js gzip 53.2 kB 53.2 kB
pages-turbo...prod.js gzip 39 kB 39 kB
pages.runtim...dev.js gzip 53.2 kB 53.2 kB
pages.runtim..prod.js gzip 39 kB 39 kB
server.runti..prod.js gzip 62.8 kB 62.8 kB
Total 3.03 MB 3.03 MB
📎 Tarball URL
https://vercel-packages.vercel.app/next/commits/4a6d432aa34953347986ef91ce5b96026b651365/next

@lukesandberg lukesandberg merged commit 6160d0d into canary Apr 3, 2026
320 of 324 checks passed
Copy link
Copy Markdown
Contributor Author

Merge activity

@lukesandberg lukesandberg deleted the revert_session_dependent_tasks_change branch April 3, 2026 21:46
eps1lon pushed a commit that referenced this pull request Apr 7, 2026
#92320)

This is causing OOMs in some applications running with a persistent cache

See discussion: https://vercel.slack.com/archives/C03EWR7LGEN/p1775159630054759

The issue appears to be invalidating the chunk graph in an odd way that causes us to allocate an ~infinite number of error strings
eps1lon pushed a commit that referenced this pull request Apr 7, 2026
#92320)

This is causing OOMs in some applications running with a persistent cache

See discussion: https://vercel.slack.com/archives/C03EWR7LGEN/p1775159630054759

The issue appears to be invalidating the chunk graph in an odd way that causes us to allocate an ~infinite number of error strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants