Skip to content

chore: conditionalize MFE config behind DEMO env var #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyphilemon merged 4 commits into from
Mar 20, 2026
+16 −11
Merged

chore: conditionalize MFE config behind DEMO env var #1463

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce6b839
chore: conditionalize MFE config behind DEMO env var
jeremyphilemon Mar 20, 2026
98dbe89
fix: use existing IS_DEMO env var instead of DEMO
jeremyphilemon Mar 20, 2026
dce8b5a
fix: move /demo redirect into next.config.ts behind IS_DEMO
jeremyphilemon Mar 20, 2026
008e5f5
fix: add basePath: false to redirect to prevent double prefixing
jeremyphilemon Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions next.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import { withBotId } from "botid/next/config";
import type { NextConfig } from "next";

const basePath = "/demo";
const basePath = process.env.IS_DEMO === "1" ? "/demo" : "";

const nextConfig: NextConfig = {
basePath,
assetPrefix: "/demo-assets",
...(basePath ? { basePath, assetPrefix: "/demo-assets" } : {}),
env: {
NEXT_PUBLIC_BASE_PATH: basePath,
},
Expand Down
9 changes: 1 addition & 8 deletions vercel.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,3 @@
{
"framework": "nextjs",
"redirects": [
{
"source": "/",
"destination": "/demo",
"permanent": false
}
]
"framework": "nextjs"
}
Loading