chore: conditionalize MFE config behind DEMO env var#1463
Merged
jeremyphilemon merged 4 commits intodemofrom Mar 20, 2026
Merged
chore: conditionalize MFE config behind DEMO env var#1463jeremyphilemon merged 4 commits intodemofrom
jeremyphilemon merged 4 commits intodemofrom
Conversation
Makes basePath and assetPrefix conditional on DEMO env var so a single branch can serve both the forkable template (no base path) and the demo deployment (mounted at /demo subpath). Removes the hardcoded redirect from vercel.json — the demo project should configure this in Vercel project settings instead.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dancer
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
basePathandassetPrefixinnext.config.tsconditional onDEMOenv var so a single branch works as both the forkable template (no base path) and the demo deployment (/demosubpath)/→/demoredirect fromvercel.json— the demo Vercel project should configure this in project settings insteadNEXT_PUBLIC_BASE_PATHreferences throughout the codebase already use?? ""fallback, so they work correctly in both modes with no changesContext
This is prep for collapsing
demoandmaininto a single branch. After merging, the demo deployment just needsDEMO=truein its Vercel project env vars.Test plan
DEMO=true— confirm app mounts at/demosubpath with asset prefixDEMO— confirm app works at root with no base path/→/demoredirect in Vercel project settings for the demo deployment