dircolors: turn integration test into unit test & remove unsafe code#12547
Open
cakebaker wants to merge 5 commits into
Open
dircolors: turn integration test into unit test & remove unsafe code#12547cakebaker wants to merge 5 commits into
cakebaker wants to merge 5 commits into
Conversation
Co-authored-by: oech3 <79379754+oech3@users.noreply.github.com> Co-authored-by: xtqqczze <45661989+xtqqczze@users.noreply.github.com>
cakebaker
force-pushed
the
dircolors_remove_unsafes
branch
from
28aa505 to
6746a52
Compare
|
GNU testsuite comparison: |
Contributor
|
Can we avoid unwrap(), unwrap(),... and unwrap() caused by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following changes:
OutputFmt::UnknownvariantCloses #12228