fix: normalize paths in workspace collection storage to prevent ghost entries#17
Merged
naman-bruno merged 2 commits intousebruno:mainfrom Apr 20, 2026
Conversation
… entries Collections reappeared after removal because of path format mismatches: - addCollectionToWorkspace stored absolute paths but normalizeCollectionEntry (which converts to relative + posixified) was never called - Duplicate entries were created when the exists-check compared a stored relative path against an incoming absolute path - Removal comparison used strict equality without path.normalize, failing on Windows where / and \ differ Fix all three: call normalizeCollectionEntry on add, resolve paths before the exists-check, and use path.normalize in the removal filter. Add e2e tests that create a collection, remove it, create another, and verify the removed one stays gone. Also fix the test fixture to dismiss the VS Code 1.116+ GitHub sign-in dialog on startup.
On Windows, the sidebar sends posixified collection paths (C:/Users/...) but generateUidBasedOnHash was called on them directly, producing a different UID than the native-path UID stored in Redux. This caused unlinkDir events from folder/request deletion to be silently dropped by the sidebar because collectionExists() couldn't match the UID. Wrap all webview-sourced collection paths in path.resolve() before hashing in renderer:delete-item, renderer:rename-item, and renderer:get-collection-tree handlers. Add e2e test for folder deletion visibility, plus createFolder and deleteItem test helpers with IPC mocks for native dialogs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Collections reappeared after removal because of path format mismatches:
Fix all three: call normalizeCollectionEntry on add, resolve paths before the exists-check, and use path.normalize in the removal filter.
Add e2e tests that create a collection, remove it, create another, and verify the removed one stays gone. Also fix the test fixture to dismiss the VS Code 1.116+ GitHub sign-in dialog on startup.