RRFS smoke fix#377
Draft
mkavulich wants to merge 1 commit into
Draft
Conversation
This was referenced Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes:
This PR fixes an issue in the current UFS code where the smoke emissions from the CFBM fire_behavior module do not persist in subsequent timesteps. Only a few instantaneous pixels of smoke can be seen in the first layer. This series of images shows smoke concentrations in the first layer at 3 h, 4 h, 5h and 6 h lead times using the current UFS weather model code:

After the fix, smoke now accumulates properly in the atmosphere over time:

Tests Conducted:
Ran the above-mentioned UFS tests with fire model enabled to show that the problem is now fixed.
UFS regression tests on Ursa are pending.
Dependencies:
Documentation:
No changes needed
Issue:
Contributors:
Fixes from Maria Frediani and Pedro Jimenez