Fixes for fire perimeter and smoke emissions from fire behavior model#3267
Draft
mkavulich wants to merge 2 commits into
Draft
Fixes for fire perimeter and smoke emissions from fire behavior model#3267mkavulich wants to merge 2 commits into
mkavulich wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Queue Requirements:
test_changes.listindicates which tests, if any, are changed by this PR. Committest_changes.list, even if it is empty.Description:
This PR incorporates fixes in submodules for two separate problems affecting the Community Fire Behavior Model in UFS:
Unrealistic fire perimeters at long forecast times
Here is an example fire area from a 6-hour and 16-hour forecast prior to the introduction of the bug:


This is the same simulated fire area with the current ufs-weather-model code:


And this is the same forecast after the fix:


Smoke emissions not persisting to subsequent timesteps
In the current UFS code the smoke emissions from the CFBM fire_behavior module do not persist in subsequent timesteps. Only a few instantaneous pixels of smoke can be seen in the first layer. This series of images shows smoke concentrations in the first layer at 3 h, 4 h, 5h and 6 h lead times using the current UFS weather model code:

After the fix, smoke now accumulates properly in the atmosphere over time:

Commit Message:
Priority:
Git Tracking
UFSWM:
Sub component Pull Requests:
UFSWM Blocking Dependencies:
Documentation:
Changes
Regression Test Changes (Please commit test_changes.list):
Input data Changes:
Library Changes/Upgrades:
Testing Log:
Testing Remarks: