Skip to content

Update memory connector doc about TRUNCATE #25649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
takezoe wants to merge 1 commit into from
Closed

Update memory connector doc about TRUNCATE #25649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/main/sphinx/connector/memory.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ statements, the connector supports the following features:

### TRUNCATE and DROP TABLE

Upon execution of a `TRUNCATE` and a `DROP TABLE` operation, memory is not released
Upon execution of a `DROP TABLE` operation, memory is not released
Copy link
Copy Markdown
Member

@ebyhr ebyhr Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now memory is released immediately (#25564)

I don't think #25564 releases memory immediately. MemoryPagesStore#purge method is called from MemoryPageSinkProvider#createPageSink. TRUNCATE statement doesn't reach there.

Copy link
Copy Markdown
Member Author

@takezoe takezoe Apr 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it is actually called next time? Thanks, I got it.

Copy link
Copy Markdown
Member Author

@takezoe takezoe Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed it. Thank you~ 🙇‍♂️

immediately. It is instead released after the next write operation to the
catalog.

Expand Down