Skip to content

Update memory connector doc about TRUNCATE#25649

Closed
takezoe wants to merge 1 commit into
trinodb:masterfrom
takezoe:fix-memory-doc-truncate
Closed

Update memory connector doc about TRUNCATE#25649
takezoe wants to merge 1 commit into
trinodb:masterfrom
takezoe:fix-memory-doc-truncate

Conversation

@takezoe
Copy link
Copy Markdown
Member

@takezoe takezoe commented Apr 22, 2025

Description

Previously, TRUNCATE on memory connector never released memory but now memory is released immediately (#25564).

The documentation needs to be updated.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot Bot added the cla-signed label Apr 22, 2025
@github-actions github-actions Bot added the docs label Apr 22, 2025
### TRUNCATE and DROP TABLE

Upon execution of a `TRUNCATE` and a `DROP TABLE` operation, memory is not released
Upon execution of a `DROP TABLE` operation, memory is not released
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now memory is released immediately (#25564)

I don't think #25564 releases memory immediately. MemoryPagesStore#purge method is called from MemoryPageSinkProvider#createPageSink. TRUNCATE statement doesn't reach there.

Copy link
Copy Markdown
Member Author

@takezoe takezoe Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it is actually called next time? Thanks, I got it.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed it. Thank you~ 🙇‍♂️

@takezoe takezoe closed this Apr 23, 2025
@takezoe takezoe deleted the fix-memory-doc-truncate branch April 23, 2025 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants