Skip to content

Add cosine_distance for sparse vectors#24027

Merged
mosabua merged 1 commit into
trinodb:masterfrom
simpligility:sparse-distance
Aug 16, 2025
Merged

Add cosine_distance for sparse vectors#24027
mosabua merged 1 commit into
trinodb:masterfrom
simpligility:sparse-distance

Conversation

@mosabua
Copy link
Copy Markdown
Member

@mosabua mosabua commented Nov 4, 2024 •
edited by ebyhr
Loading

Description

All good to go.

Additional context and related issues

follow up to #24005

Release notes

## General 

* Add the {func}`cosine_distance` function for sparse vectors. ({issue}`24027`)

@mosabua mosabua requested a review from dain November 4, 2024 18:50
@cla-bot cla-bot Bot added the cla-signed label Nov 4, 2024
@mosabua mosabua marked this pull request as draft November 4, 2024 18:50
@github-actions github-actions Bot added the docs label Nov 4, 2024
mosabua
mosabua commented Nov 4, 2024
View reviewed changes
Comment thread core/trino-main/src/test/java/io/trino/operator/scalar/TestMathFunctions.java Outdated
mosabua
mosabua commented Nov 4, 2024
View reviewed changes
Comment thread docs/src/main/sphinx/functions/math.md Outdated
@mosabua mosabua force-pushed the sparse-distance branch 4 times, most recently from 4b126bf to cb8d293 Compare November 4, 2024 19:54
@mosabua mosabua marked this pull request as ready for review November 8, 2024 17:10
@mosabua mosabua requested a review from martint November 8, 2024 17:10
mosabua
mosabua commented Nov 8, 2024
View reviewed changes
Comment thread core/trino-main/src/test/java/io/trino/operator/scalar/TestMathFunctions.java Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 2, 2024

This pull request has gone a while without any activity. Tagging for triage help: @mosabua

@github-actions github-actions Bot added the stale label Dec 2, 2024
@mosabua
Copy link
Copy Markdown
Member Author

mosabua commented Dec 2, 2024

I need to look at the test that failed and chat some more with @martint afterwards. I will keep it open and update after Trino Summit.

@github-actions github-actions Bot removed the stale label Dec 3, 2024
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 25, 2024

This pull request has gone a while without any activity. Tagging for triage help: @mosabua

@github-actions github-actions Bot added the stale label Dec 25, 2024
@mosabua mosabua force-pushed the sparse-distance branch 2 times, most recently from 74e4109 to c0211d2 Compare January 10, 2025 21:39
@mosabua
Copy link
Copy Markdown
Member Author

mosabua commented Jan 10, 2025

I need to look at the test that failed and chat some more with @martint afterwards. I will keep it open and update after Trino Summit.

@martint and @dain .. I think this is ready now

@github-actions github-actions Bot removed the stale label Jan 13, 2025
@mosabua mosabua force-pushed the sparse-distance branch 2 times, most recently from 4db1191 to 1def2e3 Compare January 29, 2025 19:15
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 20, 2025

This pull request has gone a while without any activity. Tagging for triage help: @mosabua

@github-actions github-actions Bot added the stale label Feb 20, 2025
dain
dain reviewed Feb 28, 2025
View reviewed changes
Comment thread core/trino-main/src/main/java/io/trino/operator/scalar/MathFunctions.java Outdated
@mosabua mosabua mentioned this pull request Mar 1, 2025
Merged
@github-actions github-actions Bot removed the stale label Mar 3, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2025

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

@github-actions github-actions Bot added the stale label Mar 25, 2025
@mosabua mosabua added stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. and removed stale labels Mar 27, 2025
@mosabua
Copy link
Copy Markdown
Member Author

mosabua commented Mar 27, 2025

This should be good to go.. I rebased and the tests now pass and include the null case. Can you take a look @dain and @martint ?

@mosabua
Copy link
Copy Markdown
Member Author

mosabua commented Apr 12, 2025

I rebased again .. its ready to go from my perspective @dain and @martint

dain
dain approved these changes Aug 15, 2025
View reviewed changes
Comment thread core/trino-main/src/main/java/io/trino/operator/scalar/MathFunctions.java Outdated
@mosabua
Copy link
Copy Markdown
Member Author

mosabua commented Aug 16, 2025

Test failure is unrelated. Relevant tests pass.

@mosabua mosabua merged commit ac7576b into trinodb:master Aug 16, 2025
97 of 98 checks passed
@mosabua mosabua deleted the sparse-distance branch August 16, 2025 04:16
@github-actions github-actions Bot added this to the 477 milestone Aug 16, 2025
@mosabua
Copy link
Copy Markdown
Member Author

mosabua commented Aug 16, 2025

Thank you @dain

@ebyhr ebyhr mentioned this pull request Aug 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dain dain dain approved these changes

@martint martint Awaiting requested review from martint

Assignees

No one assigned

Labels

cla-signed docs stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. syntax-needs-review

Milestone

477

Development

Successfully merging this pull request may close these issues.

4 participants

@mosabua @martint @dain @ebyhr