Fix null handling in cosine_distance and cosine_similarity#25195
Merged
Conversation
Member
|
Kinda discovered in #24027 .. I will rebase after this merged and see if there is still anything even left for me to do ;-) |
wendigo
approved these changes
Mar 1, 2025
This method scans the block to see if it has a null value.
Previously nulls were ignored producing in an arbitrary result
dain
force-pushed
the
vector-cosine-distance
branch
from
6c2d0a7 to
ddb09b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously nulls were ignored producing in an arbitrary result.
To make the implementation easier and more performant I added a hasNull method to block.
Release notes
(X) Release notes are required, with the following suggested text: