Fix columns property to handle lazy SegmentIterator from spooled protocol#599
Merged
Merged
Conversation
Commit a2a1001 made fetch() return a lazy SegmentIterator for spooled results but did not update the columns property which still used `+= self.fetch()`. This raises TypeError when _result.rows is an itertools.chain object and silently materializes the iterator when _result.rows is a list. Apply the same isinstance branching already present in execute().
hashhar
force-pushed
the
hashhar/fix-columns-lazy
branch
from
b3644dd to
fdb3ab2
Compare
wendigo
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Commit a2a1001 made fetch() return a lazy SegmentIterator for spooled results but did not update the columns property which still used
+= self.fetch(). This raises TypeError when _result.rows is an itertools.chain object and silently materializes the iterator when _result.rows is a list.Apply the same isinstance branching already present in execute().
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: