Lazily load spooled result set segments#597
Merged
Merged
Conversation
wendigo
force-pushed
the
user/serafin/oom-lazy
branch
from
a806f32 to
a913889
Compare
wendigo
force-pushed
the
user/serafin/oom-lazy
branch
2 times, most recently
from
c94a245 to
ee3d343
Compare
hashhar
reviewed
Apr 12, 2026
| # because we cannot cheaply check iterator length. | ||
| while not self.finished and not self.cancelled and self._result.rows == []: | ||
| new_rows = self.fetch() | ||
| if isinstance(new_rows, list): |
Member
There was a problem hiding this comment.
do we also need this check in columns?
Contributor
Author
There was a problem hiding this comment.
Why? I don't think we do
hashhar
reviewed
Apr 12, 2026
hashhar
reviewed
Apr 12, 2026
hashhar
reviewed
Apr 12, 2026
When using the spooling protocol, TrinoQuery.fetch() materializes all segments into a single list, causing out-of-memory errors on large result sets. Return SegmentIterator directly so rows are decoded on demand, keeping memory usage constant regardless of result set size.
wendigo
force-pushed
the
user/serafin/oom-lazy
branch
from
ee3d343 to
0aa81e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the spooling protocol, TrinoQuery.fetch() materializes all segments into a single list, causing out-of-memory errors on large result sets. Return SegmentIterator directly so rows are decoded on demand, keeping memory usage constant regardless of result set size.
Supersedes #590
Description
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: