deps upgrade v3: upgrade vite to 8 and the Svelte toolchain - #6422
Conversation
- vite ^6.2/^6.3/^7.1/^8.0 -> ^8.1.5 (14 workspaces) - @sveltejs/vite-plugin-svelte ^5/^7.1 -> ^7.2.0 - @sveltejs/kit ^2.49/^2.60 -> ^2.69.3 - @sveltejs/adapter-auto ^4 -> ^7.0.1 - svelte ^5.55.8 -> ^5.56.5 - vitest-browser-svelte ^2.1.1 -> ^3.0.0 These move together: vite-plugin-svelte 7 requires vite 7 or newer, and @uppy/svelte was already on vite ^8.0.13. One source change: examples/xhr-node/main.js imported two stylesheets from `dist/style.css` while the neighbouring line already used `css/style.css`. vite 8 resolves the stale paths strictly, so both are corrected. svelte-check now logs "Loading Svelte config from Vite config failed" in @uppy/svelte before falling back to svelte.config.js. It is noise from @sveltejs/kit's config loader reacting to a hoisted install; all 235 files are still checked (0 errors, 1 pre-existing warning). Supersedes #6340. Verified: yarn build (54/54), yarn typecheck (75/75), yarn check:ci, yarn test (19/19).
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Upgrades the repo’s Vite + Svelte/SvelteKit toolchain to newer major versions to keep the Uppy monorepo examples and the @uppy/svelte workspace compatible with the latest Vite/Svelte ecosystem, plus a small example import-path fix required by Vite 8’s stricter resolution.
Changes:
- Bump Vite to
^8.1.5across multiple workspaces/examples (and update the lockfile accordingly). - Upgrade SvelteKit-related dependencies (
@sveltejs/kit,@sveltejs/adapter-auto,@sveltejs/vite-plugin-svelte,svelte,vitest-browser-svelte) for@uppy/svelteand the SvelteKit example. - Fix
examples/xhr-node/main.jsstylesheet imports to use.../css/style.csspaths.
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updates the resolved dependency graph for the Vite 8 + Svelte toolchain upgrades. |
| private/dev/package.json | Bumps dev workspace Vite to ^8.1.5. |
| packages/@uppy/svelte/package.json | Upgrades SvelteKit + related tooling and Vite for the @uppy/svelte workspace. |
| examples/xhr-python/package.json | Bumps example Vite to ^8.1.5. |
| examples/xhr-php/package.json | Bumps example Vite to ^8.1.5. |
| examples/xhr-node/package.json | Bumps example Vite to ^8.1.5. |
| examples/xhr-node/main.js | Updates Uppy stylesheet import paths to the css/style.css entrypoints. |
| examples/xhr-bundle/package.json | Bumps example Vite to ^8.1.5. |
| examples/vue/package.json | Bumps example Vite to ^8.1.5. |
| examples/transloadit/package.json | Bumps example Vite to ^8.1.5. |
| examples/sveltekit/package.json | Upgrades SvelteKit toolchain + Vite and vitest-browser-svelte for the SvelteKit example. |
| examples/reactrouter/package.json | Bumps example Vite to ^8.1.5. |
| examples/react/package.json | Bumps example Vite to ^8.1.5. |
| examples/companion-digitalocean-spaces/package.json | Bumps example Vite to ^8.1.5. |
| examples/companion-custom-provider/package.json | Bumps example Vite to ^8.1.5. |
| examples/aws-companion/package.json | Bumps example Vite to ^8.1.5. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Stacked PR: should be merged after #6421
AI disclaimer : AI used
These move together: vite-plugin-svelte 7 requires vite 7 or newer, and @uppy/svelte was already on vite ^8.0.13.
One source change: examples/xhr-node/main.js imported two stylesheets from
dist/style.csswhile the neighbouring line already usedcss/style.css. vite 8 resolves the stale paths strictly, so both are corrected.svelte-check now logs "Loading Svelte config from Vite config failed" in @uppy/svelte before falling back to svelte.config.js. It is noise from @sveltejs/kit's config loader reacting to a hoisted install; all 235 files are still checked (0 errors, 1 pre-existing warning).