deps upgrade v4: upgrade nock, react-router and the Google Picker types - #6423
Open
qxprakash wants to merge 1 commit into
Open
deps upgrade v4: upgrade nock, react-router and the Google Picker types#6423qxprakash wants to merge 1 commit into
qxprakash wants to merge 1 commit into
Conversation
- nock ^13.1/^14.0 -> ^15.0.0 (companion tests) - react-router / @react-router/dev / @react-router/express ^7.12 -> ^7.18.1 (supersedes #6338; v8 is a separate migration) - @types/google.accounts ^0.0.14 -> ^0.0.18 - @types/google.picker ^0.0.42 -> ^0.0.52 Two source changes: nock 15 replaced the (uri, body) reply signature with a single Request, and an arity-2 reply callback is now treated as the callback style, so the old signature silently hung instead of failing. The zoom fixture and the credentials test read headers and JSON off the Request instead. @types/google.picker 0.0.52 correctly types docs, name and mimeType as optional, so showDrivePicker validates the response before importing and throws a descriptive error rather than creating a file with undefined fields. Shortcut metadata is preserved through the spread. Has a changeset. examples/nextjs/tsconfig.json picks up the Next 16 jsx and include settings. Verified: yarn build (54/54), yarn typecheck (75/75), yarn check:ci, yarn test (19/19).
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
🦋 Changeset detectedLatest commit: 19318f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
qxprakash
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades several dependencies across the monorepo (nock, react-router, and Google Picker-related type packages) and adjusts a few call sites to match updated APIs/typing, improving runtime correctness and preventing silent failures.
Changes:
- Upgraded nock to
^15.0.0and updated nock reply handlers in Companion tests/fixtures to use the newRequest-based callback. - Upgraded
react-router/@react-router/dev/@react-router/expressto^7.18.1(example app dependency refresh). - Updated Google Picker types and added response validation in
showDrivePicker, plus a changeset entry documenting the behavior change.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Locks updated dependency graph for nock/react-router/Google types and transitive changes. |
packages/@uppy/core/src/provider-views/GooglePicker/googlePicker.ts |
Validates Google Picker response/doc fields before importing; preserves shortcut metadata when recursing. |
packages/@uppy/core/package.json |
Bumps @types/google.accounts and @types/google.picker versions for @uppy/core. |
packages/@uppy/companion/test/fixtures/zoom.ts |
Updates nock reply callback to read auth header via Request.headers. |
packages/@uppy/companion/test/credentials.test.ts |
Updates nock reply callback to parse JSON from Request for remote OAuth key tests. |
packages/@uppy/companion/package.json |
Bumps Companion devDependency nock to ^15.0.0. |
packages/@uppy/aws-s3/package.json |
Bumps AWS S3 package devDependency nock to ^15.0.0. |
examples/reactrouter/package.json |
Updates react-router dependencies used by the React Router example. |
examples/nextjs/tsconfig.json |
Adjusts JSX mode and include paths to align with newer Next.js-generated type output. |
.changeset/google-picker-response-validation.md |
Adds a changeset documenting the Google Picker response validation behavior change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mifi
reviewed
Jul 28, 2026
| const results: PickedDriveItem[] = [] | ||
| for (const doc of picked.docs) { | ||
| if (!doc.name || !doc.mimeType) { | ||
| throw new Error( |
Contributor
There was a problem hiding this comment.
I think we should not throw, we should probably update the returned types accordingly: https://developers.google.com/workspace/drive/picker/reference/picker.documentobject.mimetype
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tacked PR: should be merged after #6422
AI disclaimer : AI used
Two source changes:
nock 15 replaced the (uri, body) reply signature with a single Request, and an arity-2 reply callback is now treated as the callback style, so the old signature silently hung instead of failing. The zoom fixture and the credentials test read headers and JSON off the Request instead.
@types/google.picker 0.0.52 correctly types docs, name and mimeType as optional, so showDrivePicker validates the response before importing and throws a descriptive error rather than creating a file with undefined fields. Shortcut metadata is preserved through the spread. Has a changeset.
examples/nextjs/tsconfig.json picks up the Next 16 jsx and include settings.