deps upgrade v2: upgrade TypeScript to 6 - #6421
Conversation
Moves all 43 workspaces to typescript ^6.0.3 (@uppy/companion was already pinned to 6.0.3). The two Angular workspaces stay on their own lines, ~5.7.3 and ~5.9.3, because the Angular compiler pins its supported range. TypeScript 6 reports TS2882 for side-effect imports of files it has no declarations for, which the browser tests in @uppy/dashboard, @uppy/golden-retriever and @uppy/xhr-upload hit when importing plugin CSS. Each gets a one-line ambient declaration. Nothing else changed: no source, no config, no lockfile churn beyond the compiler itself. Verified: yarn build (54/54), yarn typecheck (75/75), yarn check:ci, yarn test (19/19).
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
There was a problem hiding this comment.
Pull request overview
Upgrades the monorepo’s TypeScript toolchain to v6 (while keeping Angular workspaces on Angular-supported TypeScript patch ranges) and unblocks TS6’s TS2882 errors in a few browser-test packages by adding minimal ambient CSS module declarations.
Changes:
- Bump TypeScript to
^6.0.3across workspaces (with Angular packages staying on~5.9.3/~5.7.3). - Add
declare module '*.css'ambient declarations for packages whose browser tests side-effect import plugin CSS. - Update
yarn.lockto reflect the new TypeScript resolution(s).
Reviewed changes
Copilot reviewed 43 out of 47 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updates lockfile entries/resolutions for the TypeScript version bumps. |
| package.json | Root devDependency TypeScript bump to ^6.0.3. |
| packages/uppy/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/angular/package.json | Keeps Angular example/compiler-aligned TypeScript range by bumping patch to ~5.9.3. |
| packages/@uppy/audio/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/aws-s3/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/box/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/components/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/companion/package.json | TypeScript devDependency updated to the v6 range. |
| packages/@uppy/compressor/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/core/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/dashboard/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/dashboard/src/css.d.ts | Adds ambient CSS module declaration to fix TS2882 for side-effect CSS imports in browser tests. |
| packages/@uppy/drag-drop/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/drop-target/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/dropbox/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/facebook/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/form/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/golden-retriever/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/golden-retriever/src/css.d.ts | Adds ambient CSS module declaration to fix TS2882 for side-effect CSS imports in browser tests. |
| packages/@uppy/google-drive/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/google-drive-picker/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/google-photos-picker/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/image-editor/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/locales/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/onedrive/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/react/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/remote-sources/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/screen-capture/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/status-bar/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/svelte/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/thumbnail-generator/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/transloadit/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/tus/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/unsplash/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/url/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/vue/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/webcam/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/webdav/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/xhr-upload/package.json | TypeScript devDependency bump to ^6.0.3. |
| packages/@uppy/xhr-upload/src/css.d.ts | Adds ambient CSS module declaration to fix TS2882 for side-effect CSS imports in browser tests. |
| packages/@uppy/zoom/package.json | TypeScript devDependency bump to ^6.0.3. |
| examples/angular/package.json | Keeps Angular-supported TypeScript range by bumping patch to ~5.7.3. |
| examples/nextjs/package.json | TypeScript devDependency bump to ^6.0.3. |
| examples/react/package.json | TypeScript devDependency bump to ^6.0.3. |
| examples/reactrouter/package.json | TypeScript devDependency bump to ^6.0.3. |
| examples/sveltekit/package.json | TypeScript devDependency bump to ^6.0.3. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Stacked PR: should be merged after #6421 **AI disclaimer : AI used** - vite ^6.2/^6.3/^7.1/^8.0 -> ^8.1.5 (14 workspaces) - @sveltejs/vite-plugin-svelte ^5/^7.1 -> ^7.2.0 - @sveltejs/kit ^2.49/^2.60 -> ^2.69.3 - @sveltejs/adapter-auto ^4 -> ^7.0.1 - svelte ^5.55.8 -> ^5.56.5 - vitest-browser-svelte ^2.1.1 -> ^3.0.0 These move together: vite-plugin-svelte 7 requires vite 7 or newer, and @uppy/svelte was already on vite ^8.0.13. One source change: examples/xhr-node/main.js imported two stylesheets from `dist/style.css` while the neighbouring line already used `css/style.css`. vite 8 resolves the stale paths strictly, so both are corrected. svelte-check now logs "Loading Svelte config from Vite config failed" in @uppy/svelte before falling back to svelte.config.js. It is noise from @sveltejs/kit's config loader reacting to a hoisted install; all 235 files are still checked (0 errors, 1 pre-existing warning).
Moves all 43 workspaces to typescript ^6.0.3 (@uppy/companion was already pinned to 6.0.3). The two Angular workspaces stay on their own lines, ~5.7.3 and ~5.9.3, because the Angular compiler pins its supported range.
TypeScript 6 reports TS2882 for side-effect imports of files it has no declarations for, which the browser tests in @uppy/dashboard, @uppy/golden-retriever and @uppy/xhr-upload hit when importing plugin CSS. Each gets a one-line ambient declaration.
Nothing else changed: no source, no config, no lockfile churn beyond the compiler itself.