Skip to content

Document ACP session initialization delay #1070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbrandenburg merged 3 commits into from
Feb 3, 2026
Merged

Document ACP session initialization delay #1070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a3b5854
Initial plan
Copilot Feb 2, 2026
215344b
Changes before error encountered
Copilot Feb 2, 2026
24dda68
Add documentation comment for ACP session initialization delay
Copilot Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 6 additions & 2 deletions src/core/target-handlers/acp-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,11 @@ export class ACPTargetHandler implements TargetHandler {
process: ChildProcess,
config: ACPTargetConfig
): Promise<string> {
// Initialize protocol
// NOTE: Session creation typically takes 5-7 seconds on first run
// as the ACP client bootstraps the environment. Subsequent sessions
// with persisted sessionId are much faster.

// Initialize protocol (fast, < 1s)
await this.sendRequest(
process,
'initialize',
Expand All @@ -187,7 +191,7 @@ export class ACPTargetHandler implements TargetHandler {
config.timeout || 30
);

// Create session
// Create session (slow, 5-7s on first run)
const sessionResult = (await this.sendRequest(
process,
'session/new',
Expand Down