Document ACP session initialization delay - #1070
Merged
Merged
Conversation
Co-authored-by: tbrandenburg <40181002+tbrandenburg@users.noreply.github.com>
tbrandenburg
marked this pull request as ready for review
February 2, 2026 18:07
Copilot stopped work on behalf of
tbrandenburg due to an error
February 2, 2026 19:44
Copilot stopped work on behalf of
tbrandenburg due to an error
February 2, 2026 20:35
tbrandenburg
approved these changes
Feb 2, 2026
Co-authored-by: tbrandenburg <40181002+tbrandenburg@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add documentation comment for session initialization delay
Document ACP session initialization delay
Feb 3, 2026
tbrandenburg
approved these changes
Feb 3, 2026
This was
linked to
issues
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
initializeSessionmethod specifies a 30-second timeout without explaining why such a long timeout is needed. PoC documentation already notes session creation takes 5-7 seconds on first run, but this knowledge wasn't captured in the implementation.Changes
Added documentation to
src/core/target-handlers/acp-handler.ts:Clarifies performance characteristics and sets expectations for developers using this method.
Original prompt
This pull request was created from Copilot chat.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.