Skip to content

fix(fs): allow open, seek and fstat in the write permission sets #3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucasfernog merged 3 commits into from
Oct 10, 2026
Merged

fix(fs): allow open, seek and fstat in the write permission sets #3630

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e06708
fix(fs): allow open, seek and fstat in the write permission sets
lucasfernog Sep 23, 2026
a74b18b
use dependencies instead
lucasfernog Oct 9, 2026
a279600
Merge branch 'v2' into fix/fs-write-sets-open
lucasfernog Oct 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/fix-fs-write-sets-open.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
fs: patch
fs-js: patch
---

The `write-all` and `write-files` permissions (and so every `allow-*-write[-recursive]` set) now also allow the `open`, `seek` and `fstat` commands. `writeFile` with a `ReadableStream` uses `open` and failed with "not allowed" under these sets, and the `FileHandle` returned by `create` could not `seek` or `stat`.
4 changes: 4 additions & 0 deletions plugins/fs/permissions/write-all.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,8 @@ commands.allow = [
"write",
"write_file",
"write_text_file",
# used by `writeFile` with a stream and by the `FileHandle` returned by `create` and `open`
"open",
"seek",
"fstat",

@amrbashir amrbashir Sep 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be better to introduce permission dependencies? when a plugin defines its commands

[
  ("writeFile", ["open", "seek", "fstat"]),
  ("readFile"), []),
]

]
4 changes: 4 additions & 0 deletions plugins/fs/permissions/write-files.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,8 @@ commands.allow = [
"write",
"write_file",
"write_text_file",
# used by `writeFile` with a stream and by the `FileHandle` returned by `create` and `open`
"open",
"seek",
"fstat",
]
Loading