Repository navigation
fix(fs): allow open, seek and fstat in the write permission sets - #3630
Merged
Merged
Conversation
The stream path of writeFile calls `open`, which only the nested command list of `allow-write-file` granted (plugins/fs/permissions/write-all.toml, write-files.toml), so `fs:allow-appdata-write-recursive` and the other write sets rejected streamed writes; seek/fstat were missing for FileHandles created under these sets. Adds open, seek and fstat to write-all and write-files. This widens the write sets slightly (open is already implied by allow-write-file); the generated reference does not list set members, so nothing to regenerate.
lucasfernog
force-pushed
the
fix/fs-write-sets-open
branch
from
September 23, 2026 15:37
25557cf to
5e06708
Compare
Contributor
Package Changes Through a279600There are 3 changes which include fs with patch, fs-js with patch, single-instance with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
reviewed
Sep 24, 2026
Comment on lines
+17
to
+20
| # used by `writeFile` with a stream and by the `FileHandle` returned by `create` and `open` | ||
| "open", | ||
| "seek", | ||
| "fstat", |
Member
There was a problem hiding this comment.
Wouldn't it be better to introduce permission dependencies? when a plugin defines its commands
[
("writeFile", ["open", "seek", "fstat"]),
("readFile"), []),
]
amrbashir
approved these changes
Oct 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stream path of writeFile calls
open, which only the nested command list ofallow-write-filegranted (plugins/fs/permissions/write-all.toml, write-files.toml), sofs:allow-appdata-write-recursiveand the other write sets rejected streamed writes; seek/fstat were missing for FileHandles created under these sets.Adds open, seek and fstat to write-all and write-files. This widens the write sets slightly (open is already implied by allow-write-file); the generated reference does not list set members, so nothing to regenerate.