Handle empty fastqc reports#598
Open
Ulthran wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds graceful handling for empty FastQC reports when no per-base sequence quality data is available. Instead of failing when attempting to concatenate an empty list, the script now writes an empty report with appropriate logging.
Key Changes
- Added a check for empty quality_list after filtering out None values
- When no quality data is found, the script logs a message and writes an empty DataFrame to the output file
- Early return prevents pandas.concat from attempting to process an empty list
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+14
to
+17
| if len(quality_list) == 0: | ||
| log.write("No per-base sequence quality data found; writing empty report.\n") | ||
| pandas.DataFrame().to_csv(output_report, sep="\t", index_label="Samples") | ||
| return |
There was a problem hiding this comment.
The new empty report handling logic lacks test coverage. Consider adding unit tests to verify:
- The behavior when all input reports return None from
parse_fastqc_quality(empty quality_list) - That an empty DataFrame is correctly written to the output file
- That the appropriate log message is written
Similar workflow scripts like preprocess_report.py have comprehensive unit tests in tests/unit/test_preprocess_report.py. Consider adding a tests/unit/test_fastqc_report.py file with tests for this new functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Codex Task