[New TX Flow] Address copilot's suggestions

src/app/(sidebar)/transaction/build/components/SimulateStepContent.tsx

@@ -68,6 +68,7 @@ export const SimulateStepContent = ({
     build,
     simulate,
     setSimulateInstructionLeeway,
+    setSimulateAuthMode,
     setSimulationResult,
     setSimulationReadOnly,
     setAuthEntriesXdr,
@@ -80,7 +81,6 @@ export const SimulateStepContent = ({
   const [assemblyWarning, setAssemblyWarning] = useState("");
   const [isResourcesExpanded, setIsResourcesExpanded] = useState(false);
   const [xdrFormat, setXdrFormat] = useState<XdrFormatType | string>("json");
-  const [authMode, selectAuthMode] = useState<AuthModeType | string>("");
   const [simulationDisplay, setSimulationDisplayResult] = useState<string>("");
   const [validUntilLedgerSeq, setValidUntilLedgerSeq] = useState(0);
 
@@ -339,15 +339,16 @@ export const SimulateStepContent = ({
           {isInvokeContract ? (
             <AuthModePicker
               id="simulate-auth-mode"
-              value={authMode}
+              value={simulate.authMode}
               onChange={(mode) => {
                 resetSimulateTx();
-                selectAuthMode(mode);
+                setSimulateAuthMode(mode as AuthModeType);
               }}
               note={
                 <>
-                  This simulation shows which signatures are required. It
-                  doesn’t validate signatures or calculate final fees.{" "}
+                  &quot;Record&quot; is recommended for simulation.
+                  &quot;Record&quot; discovers which authorization entries are
+                  required.
                   <SdsLink href="https://developers.stellar.org/docs/learn/fundamentals/contract-development/contract-interactions/transaction-simulation#authorization">
                     Learn more
                   </SdsLink>

src/app/(sidebar)/transaction/build/components/ValidateStepContent.tsx

@@ -72,6 +72,10 @@ export const ValidateStepContent = () => {
   const onValidate = async () => {
     if (!network.rpcUrl || !signedXdr) return;
 
+    // Clear previous validated result so a failed re-validation can't leave
+    // stale validatedXdr enabling the next step.
+    setValidatedXdr(undefined);
+
     try {
       const response = await simulateTx({
         rpcUrl: network.rpcUrl,

src/app/(sidebar)/transaction/build/page.tsx

@@ -73,10 +73,11 @@ export default function BuildTransaction() {
       return !currentXdr || !(build.isValid.params && build.isValid.operations);
     }
     if (activeStep === "simulate") {
-      // Simulation must be complete. If auth entries exist, they must be signed
-      // (assembledXdr is set after auth signing + assembly, or after auto-assembly
-      // when no auth entries are present).
-      return !simulate.simulationResultJson;
+      // Simulation must be complete and assembledXdr must exist (set after auth
+      // signing + assembly, or after auto-assembly when no auth entries are
+      // present) so the sign step receives a transaction with
+      // simulation-derived resources/fees.
+      return !simulate.simulationResultJson || !simulate.assembledXdr;
     }
     if (activeStep === "sign") {
       return !sign.signedXdr;

src/components/FormElements/AuthModePicker.tsx

@@ -5,7 +5,7 @@ import { AuthModeType } from "@/types/types";
 const AUTH_MODE_OPTIONS: { id: string; label: string }[] = [
   { id: "record", label: "Record" },
   { id: "enforce", label: "Enforce" },
-  { id: "record-allow-nonroot", label: "Record (allow non-root)" },
+  { id: "record_allow_nonroot", label: "Record (allow non-root)" },
 ];
 
 /**

src/components/NewValidationResponseCard/index.tsx

@@ -42,7 +42,7 @@ export const NewValidationResponseCard = ({
         {/* @TODO to update the SDS design system */}
         <Alert
           placement="inline"
-          variant="success"
+          variant={variant}
           title="Your transaction envelope XDR is ready."
           icon={<Icon.CheckCircle />}
         >
@@ -83,7 +83,13 @@ export const NewValidationResponseCard = ({
                   gap="sm"
                   direction="row"
                   align="center"
-                  justify={footerLeftEl && footerRightEl ? "space-between" : footerRightEl ? "end" : "left"}
+                  justify={
+                    footerLeftEl && footerRightEl
+                      ? "space-between"
+                      : footerRightEl
+                        ? "end"
+                        : "left"
+                  }
                   addlClassName="ValidationResponseCard__footer"
                   wrap="wrap"
                 >

src/components/SorobanAuthSigning/AuthEntryItem.tsx

@@ -114,7 +114,7 @@ export const AuthEntryItem = ({
       } catch (e) {
         const msg = e instanceof Error ? e.message : String(e);
         trackEvent(TrackingEvent.SOROBAN_AUTH_SIGN_ENTRY_ERROR, {
-          entryIndex: index,
+          entryIndex: index + 1,
         });
         return { successMessage: "", errorMessage: msg };
       }

src/components/SorobanAuthSigning/index.tsx

@@ -102,9 +102,11 @@ export const SorobanAuthSigningCard = ({
   const signedCount = signedAuthEntriesXdr.filter(Boolean).length;
   const allSigned = signedCount === entryCount && entryCount > 0;
 
-  // Trigger onAllEntriesSigned when individual signing completes all entries
+  // Trigger onAllEntriesSigned when individual signing completes all entries.
+  // Only needed in individual mode — "Sign all" calls onAllEntriesSigned
+  // directly in handleCustomSignAll.
   useEffect(() => {
-    if (allSigned) {
+    if (allSigned && signMode === "individual") {
       onAllEntriesSigned(signedAuthEntriesXdr);
     }
     // Only trigger when allSigned changes to true

src/components/Tabs/index.tsx

@@ -29,15 +29,14 @@ export const Tabs = ({
         const isActive = t.href ? pathname === t.href : t.id === activeTabId;
         const className = `Tab ${addlClassName ?? ""}`;
 
-        if (t.href) {
+        if (t.href && !t.isDisabled) {
           return (
             <Link
               key={t.id}
               href={t.href}
               className={`external-link ${className}`}
               data-testid={t.id}
               data-is-active={isActive}
-              data-is-disabled={t.isDisabled ?? undefined}
             >
               {t.label}
             </Link>

src/components/TransactionStepper/index.tsx

@@ -73,6 +73,7 @@ export const TransactionStepper = ({
 
         return (
           <div
+            role="button"
             key={step}
             className="TransactionStepper__step"
             data-is-active={isActive || undefined}

src/helpers/sorobanUtils.ts

@@ -705,7 +705,7 @@ export const hasTypeAndValue = (v: any) => v?.type && v.value !== undefined;
 
 /**
  * Determines if the simulation result indicates a read-only transaction
- * (no auth entries and no write footprint).
+ * (no write footprint).
  */
 export const checkIsReadOnly = (responseData: Record<string, any>): boolean => {
   try {

src/store/createTransactionFlowStore.ts

@@ -171,8 +171,8 @@ interface TransactionFlowActions {
   /** Set the auth mode for the validate step. */
   setValidateAuthMode: (mode: AuthModeType) => void;
 
-  /** Store the validated transaction XDR. */
-  setValidatedXdr: (xdr: string) => void;
+  /** Store (or clear) the validated transaction XDR. */
+  setValidatedXdr: (xdr: string | undefined) => void;
 
   /** Update fee bump params. */
   setFeeBumpParams: (params: FeeBumpParamsObj) => void;

tests/e2e/sorobanAuthEntry.test.ts

@@ -70,6 +70,19 @@ const seedSessionStorageAndNavigate = async (page: Page) => {
   await page.evaluate(
     (stateJson) => {
       sessionStorage.setItem("stellar_lab_tx_flow_build", stateJson);
+
+      // Seed localStorage with testnet so the NetworkSelector doesn't open
+      // a "Load Network" modal on reload (CI has no saved network).
+      localStorage.setItem(
+        "stellar_lab_network",
+        JSON.stringify({
+          id: "testnet",
+          label: "Testnet",
+          horizonUrl: "https://horizon-testnet.stellar.org",
+          rpcUrl: "https://soroban-testnet.stellar.org",
+          passphrase: "Test SDF Network ; September 2015",
+        }),
+      );
     },
     JSON.stringify(storeState),
   );
@@ -158,7 +171,7 @@ test.describe("Soroban Auth Entry Detection and Signing", () => {
       await mockSimulateWithAuthEntries(page);
       await seedSessionStorageAndNavigate(page);
 
-      const simulateButton = page.getByRole("button", { name: "Simulate" });
+      const simulateButton = page.getByRole("button", { name: "Simulate", exact: true });
       await simulateButton.click();
 
       // Wait for simulation result
@@ -184,7 +197,7 @@ test.describe("Soroban Auth Entry Detection and Signing", () => {
       await mockSimulateWithoutAuthEntries(page);
       await seedSessionStorageAndNavigate(page);
 
-      const simulateButton = page.getByRole("button", { name: "Simulate" });
+      const simulateButton = page.getByRole("button", { name: "Simulate", exact: true });
       await simulateButton.click();
 
       // Wait for simulation result
@@ -208,7 +221,7 @@ test.describe("Soroban Auth Entry Detection and Signing", () => {
       await mockSimulateWithAuthEntries(page);
       await seedSessionStorageAndNavigate(page);
 
-      const simulateButton = page.getByRole("button", { name: "Simulate" });
+      const simulateButton = page.getByRole("button", { name: "Simulate", exact: true });
       await simulateButton.click();
 
       await expect(
@@ -235,7 +248,7 @@ test.describe("Soroban Auth Entry Detection and Signing", () => {
       await mockSimulateWithAuthEntries(page);
       await seedSessionStorageAndNavigate(page);
 
-      const simulateButton = page.getByRole("button", { name: "Simulate" });
+      const simulateButton = page.getByRole("button", { name: "Simulate", exact: true });
       await simulateButton.click();
 
       await expect(
@@ -258,7 +271,7 @@ test.describe("Soroban Auth Entry Detection and Signing", () => {
       await mockSimulateWithAuthEntries(page);
       await seedSessionStorageAndNavigate(page);
 
-      const simulateButton = page.getByRole("button", { name: "Simulate" });
+      const simulateButton = page.getByRole("button", { name: "Simulate", exact: true });
       await simulateButton.click();
 
       await expect(

tests/e2e/validateStepContent.test.ts

@@ -63,6 +63,19 @@ test.describe("Validate Step in Build Flow", () => {
     // Seed sessionStorage with flow store state at the validate step
     await page.evaluate((stateJson) => {
       sessionStorage.setItem("stellar_lab_tx_flow_build", stateJson);
+
+      // Seed localStorage with testnet so the NetworkSelector doesn't open
+      // a "Load Network" modal on reload (CI has no saved network).
+      localStorage.setItem(
+        "stellar_lab_network",
+        JSON.stringify({
+          id: "testnet",
+          label: "Testnet",
+          horizonUrl: "https://horizon-testnet.stellar.org",
+          rpcUrl: "https://soroban-testnet.stellar.org",
+          passphrase: "Test SDF Network ; September 2015",
+        }),
+      );
     }, JSON.stringify(storeState));
 
     // Reload to pick up the seeded sessionStorage
@@ -149,7 +162,7 @@ test.describe("Validate Step in Build Flow", () => {
   }) => {
     await seedSessionStorageAndNavigate(page);
 
-    const validateButton = page.getByRole("button", { name: "Validate" });
+    const validateButton = page.getByRole("button", { name: "Validate", exact: true });
     await expect(validateButton).toBeEnabled();
   });
 
@@ -159,7 +172,7 @@ test.describe("Validate Step in Build Flow", () => {
     await mockEnforceSimulationSuccess(page);
     await seedSessionStorageAndNavigate(page);
 
-    const validateButton = page.getByRole("button", { name: "Validate" });
+    const validateButton = page.getByRole("button", { name: "Validate", exact: true });
     await validateButton.click();
 
     // Wait for success alert
@@ -179,7 +192,7 @@ test.describe("Validate Step in Build Flow", () => {
     await mockEnforceSimulationFailure(page);
     await seedSessionStorageAndNavigate(page);
 
-    const validateButton = page.getByRole("button", { name: "Validate" });
+    const validateButton = page.getByRole("button", { name: "Validate", exact: true });
     await validateButton.click();
 
     await expect(page.getByText("Validation failed")).toBeVisible();
@@ -191,7 +204,7 @@ test.describe("Validate Step in Build Flow", () => {
     await mockEnforceSimulationSuccess(page);
     await seedSessionStorageAndNavigate(page);
 
-    const validateButton = page.getByRole("button", { name: "Validate" });
+    const validateButton = page.getByRole("button", { name: "Validate", exact: true });
     await validateButton.click();
 
     await expect(
@@ -234,7 +247,7 @@ test.describe("Validate Step in Build Flow", () => {
     await mockEnforceSimulationSuccess(page);
     await seedSessionStorageAndNavigate(page);
 
-    const validateButton = page.getByRole("button", { name: "Validate" });
+    const validateButton = page.getByRole("button", { name: "Validate", exact: true });
     await validateButton.click();
 
     // Wait for success