[New TX Flow] Address copilot's suggestions#2014
[New TX Flow] Address copilot's suggestions#2014jeesunikim wants to merge 4 commits intofeature/new-tx-flowfrom
Conversation
| /** | ||
| * Determines if the simulation result indicates a read-only transaction | ||
| * (no auth entries and no write footprint). | ||
| * (no write footprint). |
|
|
||
| return ( | ||
| <div | ||
| role="button" |
| const className = `Tab ${addlClassName ?? ""}`; | ||
|
|
||
| if (t.href) { | ||
| if (t.href && !t.isDisabled) { |
| // directly in handleCustomSignAll. | ||
| useEffect(() => { | ||
| if (allSigned) { | ||
| if (allSigned && signMode === "individual") { |
|
|
||
| // Clear previous validated result so a failed re-validation can't leave | ||
| // stale validatedXdr enabling the next step. | ||
| setValidatedXdr(undefined); |
| // signing + assembly, or after auto-assembly when no auth entries are | ||
| // present) so the sign step receives a transaction with | ||
| // simulation-derived resources/fees. | ||
| return !simulate.simulationResultJson || !simulate.assembledXdr; |
| { id: "record", label: "Record" }, | ||
| { id: "enforce", label: "Enforce" }, | ||
| { id: "record-allow-nonroot", label: "Record (allow non-root)" }, | ||
| { id: "record_allow_nonroot", label: "Record (allow non-root)" }, |
There was a problem hiding this comment.
rpc takes in _ underscore #1936 (comment)
There was a problem hiding this comment.
Might be good to add this as a comment since it breaks our convention.
|
Preview is available here: |
|
Preview is available here: |
|
Preview is available here: |
| "Record" is recommended for simulation. | ||
| "Record" discovers which authorization entries are | ||
| required. |
There was a problem hiding this comment.
It might be better to escape quote characters than encode them like this. This was is hard to read and will harder to search for this text.
| { id: "record", label: "Record" }, | ||
| { id: "enforce", label: "Enforce" }, | ||
| { id: "record-allow-nonroot", label: "Record (allow non-root)" }, | ||
| { id: "record_allow_nonroot", label: "Record (allow non-root)" }, |
There was a problem hiding this comment.
Might be good to add this as a comment since it breaks our convention.
| variant="success" | ||
| variant={variant} | ||
| title="Your transaction envelope XDR is ready." | ||
| icon={<Icon.CheckCircle />} |
There was a problem hiding this comment.
If the variant is dynamic, should the icon be dynamic as well?
2 participants
I left a direct link to the comment in each updated file