Skip to content

example: fixing ellipsoid-joint python example - #2935

Open
Ipuch wants to merge 2 commits into
stack-of-tasks:develfrom
Ipuch:topic/fix_ellispoid_example
Open

example: fixing ellipsoid-joint python example#2935
Ipuch wants to merge 2 commits into
stack-of-tasks:develfrom
Ipuch:topic/fix_ellispoid_example

Conversation

@Ipuch

@Ipuch Ipuch commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

The ellipsoid joint python example wasn't running anymore.

pin.GeometryObject in pinocchio 4 takes (name, parent_joint, placement, collision_geometry) as arguments, whereas the pinocchio 3 call sites passed geometry and placement in the opposite order, which raised a Boost.Python.ArgumentError.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:

  • build_collision (build Pinocchio with coal support)
  • build_casadi (build Pinocchio with CasADi support)
  • build_autodiff (build Pinocchio with CppAD support)
  • build_codegen (build Pinocchio with CppADCodeGen support)
  • build_extra (build Pinocchio with extra algorithms)
  • build_mpfr (build Pinocchio with Boost.Multiprecision support)
  • build_sdf (build Pinocchio with SDF parser)
  • build_accelerate (build Pinocchio with APPLE Accelerate framework support)
  • build_all (build Pinocchio with ALL the options stated above)

Thanks.
The Pinocchio development team.

@jcarpent jcarpent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you run pre-commit locally?

@Ipuch

Ipuch commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

Indeed, my python black linter interfered.

I've run pre-commit again despite some weird line breaks in the python scripts, for example:

q_composite[:3] = data.oMi[
        1
    ].translation  # Set translation to current position on ellipsoid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants