Repository navigation
feat: add coverage measurements to release workflow for release-please PRs - #66
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Add coverage measurements to release workflows
feat: add coverage measurements to release workflow for release-please PRs
Aug 2, 2026
spmse
approved these changes
Aug 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Coverage now runs as part of the release workflow when a release-please PR is opened or updated, in addition to the existing post-merge coverage in
build-release-evidence.Changes to
.github/workflows/release.yml:pull_requesttrigger (targetingmain, types:opened,synchronize,reopened) alongside the existingpushtriggerif: github.event_name == 'push'guard to therelease-pleasejob so it only fires on pushes — downstream jobs (build-release-evidence,build-documentation,deploy-documentation) are naturally skipped on PR events vianeedspropagationrelease-coveragejob runs only whengithub.event_name == 'pull_request' && startsWith(github.head_ref, 'release-please--'): installs deps, runs pytest with coverage (80% threshold), uploads to Codecov, posts a coverage comment on the PR, and uploads artifacts — mirroring the existingcoverage.ymlapproachWhy
The
coverage.ymlworkflow only triggers on changes topackages/core/src/**orpackages/core/tests/**. Release-please PRs only touch changelogs, version files, and manifests, so coverage never ran during the release lifecycle. This meant coverage info in the README could go stale without a code change to force a refresh.Validation
python -m ruff check .python -m ruff format --check .python -m pytestpython -m build --sdist --wheelDocumentation
Scope
Risks or follow-up
release-coveragejob usesgithub.head_refto detect release-please branches (release-please--**). This assumes release-please follows its standard branch naming convention.coverage.yml) — if the threshold changes in one place it should be updated in both.