fix: RS03 recognize tries all known medium sizes as candidates#153
Open
mezinster wants to merge 3 commits intospeed47:masterfrom
Open
fix: RS03 recognize tries all known medium sizes as candidates#153mezinster wants to merge 3 commits intospeed47:masterfrom
mezinster wants to merge 3 commits intospeed47:masterfrom
Conversation
Replace single-guess layer size selection with multi-candidate search. Both DM and NODM BD sizes are always tried, removing the need for --no-bdr-defect-management at recognition time. Fixes recognition of RS03 ECC data when image sector count doesn't match expected medium size (BD-RE read-back, DM/NODM mismatch). Addresses upstream issues speed47#69, speed47#97, speed47#135. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
RS03 multi-candidate search was producing verbose output for every candidate tried, breaking bash regtest golden-file comparisons. Now only the first candidate (matching old single-guess behavior) emits verbose output; subsequent candidates run quietly. Also reorder exhaustive candidates to try heuristic_layer_size() first. Fix deb build: dpkg-buildpackage calls make distclean before configure, hitting the stub Makefile. Override dh_auto_clean to skip when GNUmakefile.config doesn't exist. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove the "trying image-derived layer sizes" verbose output blocks from 32 golden database files. The RS03 multi-candidate search (commit f8d747f) replaced the old two-phase recognize flow with a single candidate loop where only the first candidate is verbose. The removed blocks contained image-derived size attempts that all failed—the new code still tries these sizes but quietly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for RS03 recognition failing on augmented images whose medium size differs from the default. Previously the recognize routine tried only one candidate medium size; now it iterates through all known sizes.
Changes
src/rs03-recognize.c: candidate-loop implementation, with verbose-output suppression so single-image scans don't get noisierregtest/database/*: golden file updates (the candidate loop changes verbose output across many bash test scenarios)debian/rules: small companion changeBackward compatibility
Existing single-size augmented images continue to be recognized identically. The change is additive — new candidate sizes are tried only when the original lookup fails.
Coordinated PR set
This PR is part of a coordinated set of four PRs from mezinster/dvdisaster. Recommended merge order:
--medium-sizeflag + macro precedence fix — independent, can merge any timeCross-reference: PRs #2, #3, #4 will be linked here once opened.