enh: --medium-size CLI flag and macro precedence fix#156
Open
mezinster wants to merge 2 commits intospeed47:masterfrom
Open
enh: --medium-size CLI flag and macro precedence fix#156mezinster wants to merge 2 commits intospeed47:masterfrom
mezinster wants to merge 2 commits intospeed47:masterfrom
Conversation
- add --medium-size CLI flag to explicitly set target medium for RS03 augmented images (CD, DVD, DVD9, BD, BD2, BDXL3, BDXL4, and NODM variants). Addresses upstream issues speed47#69 and speed47#135 where auto-detection picks the smallest fitting medium with no obvious override. - print auto-selected medium name in verbose output with hint to use --medium-size to override - fix -n with medium aliases (e.g. -n BD) in ECC file mode: gracefully fall back to default redundancy instead of erroring out - skip texlive in deb CI build by using dpkg-buildpackage -B (arch-only) - remove stale duplicate manual copy from make-dist.sh Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix CRCBUF_UPDATE_* macros missing parentheses in dvdisaster.h - Make CRCBUF_UPDATE_ALL self-documenting via bitwise OR of components - Run regression tests on push to master (not just PRs) - Eliminate tag race condition in release workflow: new prepare-tag job creates latest/devel tags once before parallel platform builds start - Cache AppImage tools (linuxdeploy, appimagetool) across runs - Add linux64-deb job to build and publish .deb packages - Update debian/control: libgtk2.0-dev -> libgtk-3-dev (GTK3 migration) - Update CodeQL actions from v2 to v3 - Add explicit contents:write permission for fork compatibility - Add CLAUDE.md for AI-assisted development context Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two unrelated but small src/-only improvements bundled for review economy:
--medium-sizeCLI flag (src/dvdisaster.c,src/rs03-common.c): explicit medium-size override on the command line. Useful when the auto-detected size needs to be forced (e.g., for testing or for unusual augmented images).src/dvdisaster.h): corrects parenthesization in a fewCRCBUF_UPDATE_*macros that could expand incorrectly when used inside complex expressions.CRCBUF_UPDATE_ALLis also now self-documenting via bitwise OR of components.Plus one packaging cleanup (
debian/control): theBuild-Dependslist still referencedlibgtk2.0-deveven thoughconfigurealready requiresgtk3 3.4.0. Replaced withlibgtk-3-devandlibglib2.0-devto match what the build actually needs.Independent of the other coordinated PRs
This PR has no test framework dependency and no CI dependency. It can merge any time, in any order relative to PRs #153, #154, #155.
Coordinated PR set
This branch is one of four coordinated PRs from mezinster/dvdisaster. The others are #153 (RS03 recognize fix), #154 (pytest framework), #155 (CI integration). Merge order is flexible for this PR.