(Requires Audit) PLEX-2473 LogPoller switch to batch inserts (Part 2)

[dhaidashenko]

Insert blocks and logs in batches to reduce DB IO usage.

Depends on: #355

[github-actions]

⚠️ API Diff Results - Breaking changes detected

📦 Module: github-com-smartcontractkit-chainlink-evm

🔴 Breaking Changes (4)

pkg/logpoller.(*DSORM) (1)

• InsertLogsWithBlock — 🗑️ Removed

pkg/logpoller.(*ObservedORM) (1)

• InsertLogsWithBlock — 🗑️ Removed

pkg/logpoller.ORM (2)

• InsertLogsWithBlock — 🗑️ Removed

• InsertLogsWithBlocks — ➕ Added

---

📄 View full apidiff report

The base branch was changed.

[github-actions]

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-evm

⚠️ Breaking Changes (4)

pkg/logpoller.(*DSORM) (1)

• InsertLogsWithBlock — 🗑️ Removed

pkg/logpoller.(*ObservedORM) (1)

• InsertLogsWithBlock — 🗑️ Removed

pkg/logpoller.ORM (2)

• InsertLogsWithBlock — 🗑️ Removed

• InsertLogsWithBlocks — ➕ Added

✅ Compatible Changes (3)

pkg/logpoller.(*DSORM) (2)

• InsertBlocks — ➕ Added

• InsertLogsWithBlocks — ➕ Added

pkg/logpoller.(*ObservedORM) (1)

• InsertLogsWithBlocks — ➕ Added

---

📄 View full apidiff report

[Copilot]

Pull request overview

This PR extends the LogPoller batching work by enabling batch insertion of blocks (and logs+blocks together) to reduce DB I/O, and refactors unfinalized log processing to accumulate blocks/logs before persisting.

Changes:

• Replaced InsertLogsWithBlock with InsertLogsWithBlocks, added InsertBlocks, and introduced a shared batchInsert helper for batched SQL inserts.
• Refactored unfinalized polling to gather blocks/logs across a range and persist them in one call, with explicit reorg detection via a typed error.
• Updated and added tests to cover block batching and adjusted polling/reorg property tests.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
pkg/logpoller/orm.go	Adds batched block insert + generic batch insert helper; updates ORM API to accept multiple blocks.
pkg/logpoller/log_poller.go	Refactors unfinalized polling flow to collect blocks/logs and batch-persist; adds reorgError plumbing.
pkg/logpoller/observability.go	Updates observed ORM wrapper for the new insert API and block-count tracking.
pkg/logpoller/orm_test.go	Adds a block batching test and updates call sites for the new insert API.
pkg/logpoller/observability_test.go	Updates tests to call the new insert API.
pkg/logpoller/log_poller_test.go	Adjusts property test randomness and poll start block handling.
pkg/logpoller/helper_test.go	Updates canonical-hash assertions to compare via string formatting.

Comments suppressed due to low confidence (1)

pkg/logpoller/orm.go:576

• InsertLogsWithBlocks currently allows inserting logs when blocks is empty (InsertBlocks becomes a no-op). This changes the old InsertLogsWithBlock contract (which always persisted the accompanying block) and can lead to logs existing without corresponding entries in log_poller_blocks, breaking confirmation-based queries and reorg detection. Consider returning an error when len(logs) > 0 && len(blocks) == 0, or documenting/enforcing the intended behavior.

func (o *DSORM) InsertLogsWithBlocks(ctx context.Context, logs []Log, blocks []Block) error {
	// Optimization, don't open TX when there is only a block to be persisted
	if len(logs) == 0 {
		return o.InsertBlocks(ctx, blocks)
	}

	if err := o.validateLogs(logs); err != nil {
		return err
	}

	// Block and logs goes with the same TX to ensure atomicity
	return o.Transact(ctx, func(orm *DSORM) error {
		err := orm.InsertBlocks(ctx, blocks)
		if err != nil {
			return err
		}
		return orm.insertLogsWithinTx(ctx, logs, orm.ds)
	})

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.