(Requires Audit) PLEX-2473 LogPoller Fix Reorg Handing on Replay (Part 1)

[dhaidashenko]

TestCase that were previously failing:

1. LogPoller processes blocks to block 11
2. Reorg replaces block 11 with a new block (some additional blocks may be added on top of it)
3. Replay is initiated from block below 11.

Expected behaviour:

1. LogPoller must replace reorged block 11 with a new data.
2. DB must not contain at any point logs from both old and new block 11.
3. Finality Violation must not occur, since chain did not violate finality depth.

Supports: #356

[github-actions]

⚠️ API Diff Results - Breaking changes detected

📦 Module: github-com-smartcontractkit-chainlink-evm

🔴 Breaking Changes (2)

pkg/logpoller.(*logPoller) (1)

• PollAndSaveLogs — Type changed:

func(
  context.Context, 
  - int64
  + int64, 
  + bool
)

pkg/logpoller.LogPollerTest (1)

• PollAndSaveLogs — Type changed:

func(
  context.Context, 
  - int64
  + int64, 
  + bool
)

---

📄 View full apidiff report

[Copilot]

Pull request overview

This PR fixes reorg (reorganization) handling in the LogPoller when replay operations encounter blocks that have been reorged. The core issue was that when LogPoller processed blocks up to block N, then a reorg replaced block N, and a replay was initiated from a block below N, the old and new versions of block N could coexist in the database, or a false finality violation could occur.

Changes:

• Added isReplay boolean parameter to PollAndSaveLogs method and related internal functions to enable special reorg detection logic during replay operations
• Extracted headerByNumber helper method to reduce code duplication when fetching block headers from RPC
• Enhanced getCurrentBlockMaybeHandleReorg to detect reorgs during replay by checking if current and latest blocks in DB match their RPC counterparts
• Refactored reorg handling logic into a new handleReorg method for better code organization
• Added comprehensive test case covering three scenarios: replay immediately after reorg, replay a few blocks after reorg, and replay after reorged block is finalized

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.

File	Description
pkg/logpoller/log_poller.go	Core implementation changes: added isReplay parameter, extracted headerByNumber and handleReorg methods, enhanced reorg detection logic for replay scenarios
pkg/logpoller/log_poller_test.go	Updated all test calls to include isReplay=false parameter, added comprehensive TestLogPoller_Reorg_On_Replay test with three test cases
pkg/logpoller/log_poller_internal_test.go	Updated all test calls to include isReplay=false parameter
pkg/logpoller/helper_test.go	Updated PollAndSaveLogs wrapper to pass isReplay=false

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

This PR is stale because it has been open 30 days with no activity.
Remove the stale label or comment or this will be closed in 7 days.

[github-actions]

This PR has been automatically closed because it has been stale for > 30 days.
If you wish to continue working on this PR, please reopen it and make any necessary changes.

[github-actions]

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-evm

⚠️ Breaking Changes (2)

pkg/logpoller.(*logPoller) (1)

• PollAndSaveLogs — Type changed:

func(
  context.Context, 
  int64, 
  + bool
)

pkg/logpoller.LogPollerTest (1)

• PollAndSaveLogs — Type changed:

func(
  context.Context, 
  int64, 
  + bool
)

---

📄 View full apidiff report